Issue 209073: Merge 26476 - Fixed a few data races on reference counters....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209073: Merge 26476 - Fixed a few data races on reference counters.... (Closed)

Created:
11 years, 3 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), darin (slow to review), brettw, willchan no longer on Chromium, Erik does not do reviews

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 26476 - Fixed a few data races on reference counters. BUG=18488 Review URL: http://codereview.chromium.org/215011 TBR=timurrrr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26883

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
MM	chrome/browser/extensions/user_script_master.h	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/browser/history/history_marshaling.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
MM	net/base/host_resolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Please amend http://codereview.chromium.org/213025 as well (patches UserScriptMaster::ScriptReloader to be RefCountedThreadSafe)

11 years, 3 months ago (2009-09-23 06:27:25 UTC) #2

laforge

11 years, 3 months ago (2009-09-23 06:45:09 UTC) #3

Let me start by saying a double thank you thank you for these patches, I'm
exceptionally pleased to have what appears to be a fix for one of our worst
and most persistent crashers.
Regarding the second patch, I think we should be ok to not to take it since
extensions are explicitly disabled in Chrome 3.0.
Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA

On Tue, Sep 22, 2009 at 11:27 PM, <timurrrr@chromium.org> wrote:

> Please amend http://codereview.chromium.org/213025 as well
> (patches UserScriptMaster::ScriptReloader to be RefCountedThreadSafe)
>
>
> http://codereview.chromium.org/209073
>

Expand Messages | Collapse Messages