Chromium Code Reviews

Issue 209068: Disable flaky plugin tests. (Closed)

Created:
11 years, 3 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Disable flaky plugin tests. These keep causing bogus automatic tree closures. BUG=21538, 22666 TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26841

Patch Set 1 #

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Stats (+4 lines, -2 lines)
M chrome/test/plugin/plugin_test.cpp View 2 chunks +4 lines, -2 lines 0 comments

Messages

Total messages: 2 (0 generated)
stuartmorgan
11 years, 3 months ago (2009-09-22 18:39:01 UTC) #1
M-A Ruel
11 years, 3 months ago (2009-09-22 18:43:33 UTC) #2
lgtm

On Sep 22, 2009 2:39 PM, <stuartmorgan@chromium.org> wrote:

Reviewers: Marc-Antoine Ruel,

Description:
Disable flaky plugin tests.
These keep causing bogus automatic tree closures.

BUG=21538,22666
TEST=N/A

Please review this at http://codereview.chromium.org/209068

Affected files:
 M chrome/test/plugin/plugin_test.cpp


Index: chrome/test/plugin/plugin_test.cpp
diff --git a/chrome/test/plugin/plugin_test.cpp
b/chrome/test/plugin/plugin_test.cpp
index
8eac844deabe59ded94145584ade417118192147..65eca9a65dbdc312ecbb0c2bdfab63153ec6ba90
100644
--- a/chrome/test/plugin/plugin_test.cpp
+++ b/chrome/test/plugin/plugin_test.cpp
@@ -169,7 +169,8 @@ TEST_F(PluginTest, FlashSecurity) {
 }

 // http://crbug.com/16114
-TEST_F(PluginTest, FlashLayoutWhilePainting) {
+// Disabled for http://crbug.com/21538
+TEST_F(PluginTest, DISABLED_FlashLayoutWhilePainting) {
  TestPlugin(L"flash-layout-while-painting.html", kShortWaitTimeout, true);
 }

@@ -178,6 +179,7 @@ TEST_F(PluginTest, DISABLED_Java) {
  TestPlugin(L"Java.html", kShortWaitTimeout, false);
 }

-TEST_F(PluginTest, Silverlight) {
+// Disabled for http://crbug.com/22666
+TEST_F(PluginTest, DISABLED_Silverlight) {
  TestPlugin(L"silverlight.html", kShortWaitTimeout, false);
 }

Powered by Google App Engine