Issue 209033: Fix coverity issue found in flaky DownloadTest, which should also decrease flakiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209033: Fix coverity issue found in flaky DownloadTest, which should also decrease flakiness. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), Paul Godavari, mattm

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix coverity issue found in flaky DownloadTest, which should also decrease flakiness. Big thanks to mattm for finding the issue! TEST=none BUG=20809 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26629

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	chrome/browser/download/download_uitest.cc	View		2 chunks	+8 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm http://codereview.chromium.org/209033/diff/1/2 File chrome/browser/download/download_uitest.cc (left): http://codereview.chromium.org/209033/diff/1/2#oldcode156 Line 156: CloseHandle(file); So I see that the CloseHandle ...

11 years, 3 months ago (2009-09-18 18:08:18 UTC) #2

lgtm too

Expand Messages | Collapse Messages