Fix coverity issue found in flaky DownloadTest, which should also decrease flakiness.

chrome/browser/download/download_uitest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 #include <string>
 
 #include "build/build_config.h"
 #if defined(OS_WIN)
 #include <shlwapi.h>
@@ skipping 115 matching lines @@
       if (file_util::Delete(download_path, false))
         break;
       PlatformThread::Sleep(action_max_timeout_ms() / 10);
     }
     EXPECT_FALSE(file_util::PathExists(download_path));
   }
 
 #if defined(OS_WIN)
   // Checks if the ZoneIdentifier is correctly set to "Internet" (3)
   void CheckZoneIdentifier(const std::wstring full_path) {
-    const DWORD kShare = FILE_SHARE_READ |
-                         FILE_SHARE_WRITE |
-                         FILE_SHARE_DELETE;
-
     std::wstring path = full_path + L":Zone.Identifier";
-    HANDLE file = CreateFile(path.c_str(), GENERIC_READ, kShare, NULL,
-                             OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
-    ASSERT_TRUE(INVALID_HANDLE_VALUE != file);
 
     // This polling and sleeping here is a very bad pattern. But due to how
     // Windows file semantics work it's really hard to do it other way. We are
     // reading a file written by a different process, using a different handle.
     // Windows does not guarantee that we will get the same contents even after
     // the other process closes the handle, flushes the buffers, etc.
     for (int i = 0; i < 20; i++) {
       PlatformThread::Sleep(sleep_timeout_ms());
 
+      const DWORD kShare = FILE_SHARE_READ |
+                           FILE_SHARE_WRITE |
+                           FILE_SHARE_DELETE;
+      HANDLE file = CreateFile(path.c_str(), GENERIC_READ, kShare, NULL,
+                               OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
+      if (file == INVALID_HANDLE_VALUE)
+        continue;
+
       char buffer[100] = {0};
       DWORD read = 0;
       BOOL read_result = ReadFile(file, buffer, 100, &read, NULL);
       CloseHandle(file);

[cpu_(ooo_6.6-7.5), 2009/09/18 18:08:18]

So I see that the CloseHandle of line 156 was a bug. Sorry I missed it.

 
       if (!read_result)
         continue;
 
       const char kIdentifier[] = "[ZoneTransfer]\nZoneId=3";
       if (read != arraysize(kIdentifier))
         continue;
 
       if (strcmp(kIdentifier, buffer) == 0)
         return;
@@ skipping 180 matching lines @@
   ASSERT_EQ(1, window_count);
 
   // Verify that the regular window does not have a download shelf.
   browser->IsShelfVisible(&is_shelf_visible);
   EXPECT_FALSE(is_shelf_visible);
 
   CleanUpDownload(file);
 }
 
 }  // namespace