Update chrome.gyp to build the sync library on Linux.

Update chrome.gyp to build the sync library on Linux.

[ncarter (slow), 2009-09-18 14:54:21]

http://codereview.chromium.org/209026/diff/1/2
File chrome/chrome.gyp (right):

http://codereview.chromium.org/209026/diff/1/2#newcode4564
Line 4564: 'POSIX',
Chromium keeps an OS_POSIX defined in build/build_config.h.  I've already
migrated the old OS_WINDOWS references to OS_WIN, so we should probably do the
same thing here with OS_POSIX, if possible.

http://codereview.chromium.org/209026/diff/1/2#newcode6329
Line 6329: 'OS_LINUX',
build/build_config.h defines OS_LINUX.  Is it possible to include that?

FWIW, I just noticed that COMPILER_MSVC is defined in build_config.h as well, so
we may not need any of these supplemental #defines.

[zork, 2009-09-18 18:10:29]

I agree with these points.  Also, we should rename any file that's platform
specific to be picked up by the regex, i.e. data_encryption_win.cc.  I'm
planning to make those changes in a later CL, though, so that I can keep the
changes small and targeted.
On Fri, Sep 18, 2009 at 7:54 AM, <nick@chromium.org> wrote:

>
> http://codereview.chromium.org/209026/diff/1/2
> File chrome/chrome.gyp (right):
>
> http://codereview.chromium.org/209026/diff/1/2#newcode4564
> Line 4564: 'POSIX',
> Chromium keeps an OS_POSIX defined in build/build_config.h.  I've
> already migrated the old OS_WINDOWS references to OS_WIN, so we should
> probably do the same thing here with OS_POSIX, if possible.
>
> http://codereview.chromium.org/209026/diff/1/2#newcode6329
> Line 6329: 'OS_LINUX',
> build/build_config.h defines OS_LINUX.  Is it possible to include that?
>
> FWIW, I just noticed that COMPILER_MSVC is defined in build_config.h as
> well, so we may not need any of these supplemental #defines.
>
>
> http://codereview.chromium.org/209026
>

[ncarter (slow), 2009-09-21 17:35:12]

OK.  LGTM then if you'll fix the usage of OS_POSIX in a follow-on change.

I'll take care of removing the COMPILER_MSVC issue on Windows.