Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5571)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/cocoa/browser_window_cocoa.mm

Issue 209020: Allow popup windows to have a title displayed in the titlebar.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_cocoa.mm
===================================================================
--- chrome/browser/cocoa/browser_window_cocoa.mm (revision 26472)
+++ chrome/browser/cocoa/browser_window_cocoa.mm (working copy)
@@ -98,6 +98,12 @@
NSString* newTitle =
base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab());
+ // Only set the title if we're a popup window. If we call setTitle on a
+ // regular browser window, it will show up in the titlle bar and cover the
+ // tab strip.
+ if (browser_->type() == Browser::TYPE_POPUP)
+ [window_ setTitle:newTitle];
+
// Window menu
[NSApp changeWindowsItem:window_ title:newTitle filename:NO];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698