Allow popup windows to have a title displayed in the titlebar....

chrome/browser/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/gfx/rect.h"
 #include "base/logging.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
 #include "chrome/browser/cocoa/browser_window_cocoa.h"
 #import "chrome/browser/cocoa/browser_window_controller.h"
@@ skipping 80 matching lines @@
 }
 
 void BrowserWindowCocoa::SelectedTabExtensionShelfSizeChanged() {
   NOTIMPLEMENTED();
 }
 
 void BrowserWindowCocoa::UpdateTitleBar() {
   NSString* newTitle =
       base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab());
 
+  // Only set the title if we're a popup window. If we call setTitle on a
+  // regular browser window, it will show up in the titlle bar and cover the
+  // tab strip.
+  if (browser_->type() == Browser::TYPE_POPUP)
+    [window_ setTitle:newTitle];
+
   // Window menu
   [NSApp changeWindowsItem:window_ title:newTitle filename:NO];
 
   // Dock
   [window_ setMiniwindowTitle:newTitle];
 }
 
 void BrowserWindowCocoa::UpdateDevTools() {
   NOTIMPLEMENTED();
 }
@@ skipping 206 matching lines @@
       break;
   }
 }
 
 void BrowserWindowCocoa::DestroyBrowser() {
   [controller_ destroyBrowser];
 
   // at this point the controller is dead (autoreleased), so
   // make sure we don't try to reference it any more.
 }