Fix false positive reporting of exceptions picked up during calls to LoadLibr...

Fix false positive reporting of exceptions picked up during calls to LoadLibrary during DllRegisterServer.

BUG=44468
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47696

[amit, 2010-05-19 18:47:39]

OK

On Tue, May 18, 2010 at 4:55 PM, <robertshield@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix false positive reporting of exceptions picked up during calls to
> LoadLibrary
> during DllRegisterServer.
>
> BUG=44468
>
>
>
> Please review this at http://codereview.chromium.org/2089016/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_tab.cc
>
>
> Index: chrome_frame/chrome_tab.cc
> ===================================================================
> --- chrome_frame/chrome_tab.cc  (revision 47422)
> +++ chrome_frame/chrome_tab.cc  (working copy)
> @@ -28,6 +28,7 @@
>  #include "chrome_frame/chrome_active_document.h"
>  #include "chrome_frame/chrome_frame_activex.h"
>  #include "chrome_frame/chrome_frame_automation.h"
> +#include "chrome_frame/exception_barrier.h"
>  #include "chrome_frame/chrome_frame_reporting.h"
>  #include "chrome_frame/chrome_launcher.h"
>  #include "chrome_frame/chrome_protocol.h"
> @@ -234,6 +235,13 @@
>   const wchar_t kIEFrameDll[] = L"ieframe.dll";
>   const char kIERefreshPolicy[] = "IERefreshElevationPolicy";
>   HRESULT hr = E_NOTIMPL;
> +
> +  // Stick an SEH in the chain to prevent the VEH from picking up on first
> +  // chance exceptions caused by loading ieframe.dll. Use the vanilla
> +  // ExceptionBarrier to report any exceptions that do make their way to
> us
> +  // though.
> +  ExceptionBarrier barrier;
> +
>   HMODULE ieframe_module = LoadLibrary(kIEFrameDll);
>   if (ieframe_module) {
>     typedef HRESULT (__stdcall *IERefreshPolicy)();
>
>
>