Fix false positive reporting of exceptions picked up during calls to LoadLibr...

chrome_frame/chrome_tab.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // chrome_tab.cc : Implementation of DLL Exports.
 
 // Include without path to make GYP build see it.
 #include "chrome_tab.h"  // NOLINT
 
 #include <atlsecurity.h>
@@ skipping 10 matching lines @@
 #include "base/string_piece.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "base/win_util.h"
 #include "chrome/common/chrome_constants.h"
 #include "grit/chrome_frame_resources.h"
 #include "chrome_frame/bho.h"
 #include "chrome_frame/chrome_active_document.h"
 #include "chrome_frame/chrome_frame_activex.h"
 #include "chrome_frame/chrome_frame_automation.h"
+#include "chrome_frame/exception_barrier.h"
 #include "chrome_frame/chrome_frame_reporting.h"
 #include "chrome_frame/chrome_launcher.h"
 #include "chrome_frame/chrome_protocol.h"
 #include "chrome_frame/module_utils.h"
 #include "chrome_frame/resource.h"
 #include "chrome_frame/utils.h"
 #include "googleurl/src/url_util.h"
 
 namespace {
 // This function has the side effect of initializing an unprotected
@@ skipping 186 matching lines @@
     hr = E_UNEXPECTED;
   }
 
   return hr;
 }
 
 HRESULT RefreshElevationPolicy() {
   const wchar_t kIEFrameDll[] = L"ieframe.dll";
   const char kIERefreshPolicy[] = "IERefreshElevationPolicy";
   HRESULT hr = E_NOTIMPL;
+
+  // Stick an SEH in the chain to prevent the VEH from picking up on first
+  // chance exceptions caused by loading ieframe.dll. Use the vanilla
+  // ExceptionBarrier to report any exceptions that do make their way to us
+  // though.
+  ExceptionBarrier barrier;
+
   HMODULE ieframe_module = LoadLibrary(kIEFrameDll);
   if (ieframe_module) {
     typedef HRESULT (__stdcall *IERefreshPolicy)();
     IERefreshPolicy ie_refresh_policy = reinterpret_cast<IERefreshPolicy>(
         GetProcAddress(ieframe_module, kIERefreshPolicy));
 
     if (ie_refresh_policy) {
       hr = ie_refresh_policy();
     } else {
       hr = HRESULT_FROM_WIN32(GetLastError());
@@ skipping 340 matching lines @@
     sd.GetDacl(&new_dacl);
     new_dacl.AddAllowedAce(token_.GetUser(), GENERIC_WRITE | GENERIC_READ);
     if (AtlSetDacl(object_name.c_str(), SE_REGISTRY_KEY, new_dacl)) {
       result = SetOrDeleteMimeHandlerKey(enable);
     }
   }
 
   backup.RestoreSecurity(object_name.c_str());
   return result;
 }