Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 208068: Desktop Notifications UI (for windows) (Closed)

Created:
11 years, 3 months ago by John Gregg
Modified:
9 years ago
Reviewers:
michaeln, jorlow
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Desktop Notifications UI (for windows) Last major piece of code for desktop notifications in pages.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1693 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/browser_process.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 3 chunks +11 lines, -0 lines 0 comments Download
A chrome/browser/notifications/balloon_contents_win.h View 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/browser/notifications/balloon_contents_win.cc View 1 chunk +129 lines, -0 lines 0 comments Download
A chrome/browser/notifications/balloon_view_win.h View 1 chunk +131 lines, -0 lines 0 comments Download
A chrome/browser/notifications/balloon_view_win.cc View 1 chunk +386 lines, -0 lines 0 comments Download
A chrome/browser/notifications/balloon_win.cc View 1 chunk +294 lines, -0 lines 0 comments Download
A chrome/browser/notifications/balloons.h View 1 chunk +191 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification.h View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_object_proxy.h View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_object_proxy.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_ui_manager.h View 1 chunk +61 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_ui_manager_win.cc View 1 chunk +101 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +41 lines, -0 lines 0 comments Download
M chrome/test/testing_browser_process.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
John Gregg
here's the last big piece of code for notifications, the UI. I've pulled out all ...
11 years, 3 months ago (2009-09-22 21:09:56 UTC) #1
John Gregg
Adding michaeln... this is the other half of the notifications code you're looking at.
11 years, 2 months ago (2009-10-09 16:48:22 UTC) #2
jorlow
11 years, 2 months ago (2009-10-09 16:52:57 UTC) #3
Btw, next time I think it'll be WELL worth the effort to do a "real" split.
 I.e. splitting this into multiple patches that don't depend on each other
and add little bits of the feature at a time.  The amount of time we've all
spent on this review has been FAR more than what it would have taken to
re-write the patch in stages and then do it in smaller reviews.  Honestly, I
think we would have been able to do better reviews as well.

On Fri, Oct 9, 2009 at 9:48 AM, <johnnyg@chromium.org> wrote:

> Adding michaeln... this is the other half of the notifications code you're
> looking at.
>
> http://codereview.chromium.org/208068
>

Powered by Google App Engine
This is Rietveld 408576698