Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 208060: gclient: store revision as a string and not int (Closed)

Created:
11 years, 3 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

gclient: store revision as a string and not int Currently, revision numbers are stored as int. This won't work for git's SHA1s. So storing revisions as strings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M gclient.py View 5 chunks +7 lines, -7 lines 0 comments Download
M gclient_scm.py View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mandeep Singh Baines
11 years, 3 months ago (2009-09-22 17:18:01 UTC) #1
msb
ping On Tue, Sep 22, 2009 at 10:18 AM, <msb@chromium.org> wrote: > Reviewers: Marc-Antoine Ruel, ...
11 years, 3 months ago (2009-09-23 15:14:34 UTC) #2
M-A Ruel
11 years, 3 months ago (2009-09-23 15:23:46 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698