Issue 208056: Changing the grd files in chrome.gyp to be compiled to seprate directories to...

Issue 208056: Changing the grd files in chrome.gyp to be compiled to seprate directories to... (Closed)

Created:
11 years, 3 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews, yaar, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Changing the grd files in chrome/webkit/app to be compiled to seprate directories to prevent them from stomping each other when they have names that are the same. Also adding some dependencies on theme_resources, webkit_resources, that were missing, but undetected due to everyone sharing the same output directory. BUG=22385 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26904

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Total comments: 12

Patch Set 14 : '' #

Patch Set 15 : '' #

Patch Set 16 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+378 lines, -369 lines)			Patch
M	app/app.gyp	View	7 8 9 10 11 12 13 14 15	7 chunks	+23 lines, -24 lines	0 comments	Download
M	chrome/app/locales/locales.gyp	View	7 8 9 10 11 12 13 14 15	2 chunks	+307 lines, -301 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	17 chunks	+33 lines, -23 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	8 9 10 11 12 13 14 15	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/webkit.gyp	View	7 8 9 10 11 12 13 14 15	5 chunks	+14 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

Yaar, can you also comment on how this will mesh with the stuff landed in ...

11 years, 3 months ago (2009-09-22 20:01:54 UTC) #2

sgk

http://codereview.chromium.org/208056/diff/7002/8007 File app/app.gyp (right): http://codereview.chromium.org/208056/diff/7002/8007#newcode246 Line 246: 'grit_path': '../tools/grit/grit.py', I'd like to see grit_path defined ...

11 years, 3 months ago (2009-09-22 20:33:11 UTC) #3

bradn

11 years, 3 months ago (2009-09-23 00:06:29 UTC) #4

Have another look.

ping yaar.

http://codereview.chromium.org/208056/diff/7002/8007
File app/app.gyp (right):

http://codereview.chromium.org/208056/diff/7002/8007#newcode246
Line 246: 'grit_path': '../tools/grit/grit.py',
On 2009/09/22 20:33:11, sgk wrote:
> I'd like to see grit_path defined up in the global variables section next to
> grit_info_cmd.  They should also probably be named in parallel, either both
> *_path or both *_cmd.

Done.

http://codereview.chromium.org/208056/diff/7002/8007#newcode256
Line 256:
'<(SHARED_INTERMEDIATE_DIR)/app/<(RULE_INPUT_ROOT)/grit/<(RULE_INPUT_ROOT).h',
On 2009/09/22 20:33:11, sgk wrote:
> Could (should?) be:
> 
> '<(grit_out_dir)/<(RULE_INPUT_ROOT)/grit/...'
> 

Done.

http://codereview.chromium.org/208056/diff/7002/8007#newcode258
Line 258: '>!@(<(apply_locales_cmd)
\'<(SHARED_INTERMEDIATE_DIR)/app/<(RULE_INPUT_ROOT)/<(RULE_INPUT_ROOT)_ZZLOCALE.pak\'
<(locales))',
On 2009/09/22 20:33:11, sgk wrote:
> Ditto.

Done.

http://codereview.chromium.org/208056/diff/7002/8007#newcode290
Line 290: 'grit_path': '../tools/grit/grit.py',
On 2009/09/22 20:33:11, sgk wrote:
> Move to global variables at top of file.
> 

Done.

http://codereview.chromium.org/208056/diff/7002/8008
File webkit/webkit.gyp (right):

http://codereview.chromium.org/208056/diff/7002/8008#newcode240
Line 240: 'grit_path': '../tools/grit/grit.py',
On 2009/09/22 20:33:11, sgk wrote:
> Let's move this path up to the top, too.

Done.

http://codereview.chromium.org/208056/diff/7002/8008#newcode275
Line 275: 'grit_path': '../tools/grit/grit.py',
On 2009/09/22 20:33:11, sgk wrote:
> And this....

Done.

Expand Messages | Collapse Messages