Chromium Code Reviews

Unified Diff: webkit/webkit.gyp

Issue 208056: Changing the grd files in chrome.gyp to be compiled to seprate directories to... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « webkit/tools/test_shell/test_shell.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/webkit.gyp
===================================================================
--- webkit/webkit.gyp (revision 26805)
+++ webkit/webkit.gyp (working copy)
@@ -8,7 +8,10 @@
],
'variables': {
# TODO: remove this helper when we have loops in GYP
- 'apply_locales_cmd': ['python', '../chrome/tools/build/apply_locales.py',],
+ 'apply_locales_cmd': ['python', '../chrome/tools/build/apply_locales.py'],
+ 'grit_info_cmd': ['python', '../tools/grit/grit_info.py'],
+ 'grit_cmd': ['python', '../tools/grit/grit.py'],
+ 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/webkit',
},
'targets': [
{
@@ -235,10 +238,6 @@
'target_name': 'webkit_resources',
'type': 'none',
'msvs_guid': '0B469837-3D46-484A-AFB3-C5A6C68730B9',
- 'variables': {
- 'grit_path': '../tools/grit/grit.py',
- 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/webkit',
- },
'actions': [
{
'action_name': 'webkit_resources',
@@ -246,20 +245,19 @@
'input_path': 'glue/webkit_resources.grd',
},
'inputs': [
- '<(input_path)',
+ '<!@(<(grit_info_cmd) --inputs <(input_path))',
],
'outputs': [
- '<(grit_out_dir)/grit/webkit_resources.h',
- '<(grit_out_dir)/webkit_resources.pak',
- '<(grit_out_dir)/webkit_resources.rc',
+ '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)/webkit_resources\' <(input_path))',
],
- 'action': ['python', '<(grit_path)', '-i', '<(input_path)', 'build', '-o', '<(grit_out_dir)'],
+ 'action': ['<@(grit_cmd)', '-i', '<(input_path)', 'build',
+ '-o', '<(grit_out_dir)/webkit_resources'],
'message': 'Generating resources from <(input_path)',
},
],
'direct_dependent_settings': {
'include_dirs': [
- '<(SHARED_INTERMEDIATE_DIR)/webkit',
+ '<(grit_out_dir)/webkit_resources',
],
},
'conditions': [
@@ -272,10 +270,6 @@
'target_name': 'webkit_strings',
'type': 'none',
'msvs_guid': '60B43839-95E6-4526-A661-209F16335E0E',
- 'variables': {
- 'grit_path': '../tools/grit/grit.py',
- 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/webkit',
- },
'actions': [
{
'action_name': 'webkit_strings',
@@ -283,20 +277,19 @@
'input_path': 'glue/webkit_strings.grd',
},
'inputs': [
- '<(input_path)',
+ '<!@(<(grit_info_cmd) --inputs <(input_path))',
],
'outputs': [
- '<(grit_out_dir)/grit/webkit_strings.h',
- # TODO: remove this helper when we have loops in GYP
- '>!@(<(apply_locales_cmd) \'<(grit_out_dir)/webkit_strings_ZZLOCALE.pak\' <(locales))',
+ '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)/webkit_strings\' <(input_path))',
],
- 'action': ['python', '<(grit_path)', '-i', '<(input_path)', 'build', '-o', '<(grit_out_dir)'],
+ 'action': ['<@(grit_cmd)', '-i', '<(input_path)', 'build',
+ '-o', '<(grit_out_dir)/webkit_strings'],
'message': 'Generating resources from <(input_path)',
},
],
'direct_dependent_settings': {
'include_dirs': [
- '<(SHARED_INTERMEDIATE_DIR)/webkit',
+ '<(grit_out_dir)/webkit_strings',
],
},
'conditions': [
« no previous file with comments | « webkit/tools/test_shell/test_shell.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine