Upstreamings parts of webkit.gyp (step 2)

Upstreamings parts of webkit.gyp (step 2)

This is step 2 a multi-step process that is part of the webkit chromium port. 

This step includes:
A. features.gypi only defines features now. Non-feature defines were propagated to their proper places in webcore & wtf.
B. Config.gyp is eliminated. It used to be that wtf, pcre & webcore all depended on it. The dependency chain was linearized by creating wtf_config (inside javascriptcore.gyp), which only wtf depends on and then then pcre & webcore depending on wtf.

Next steps:
* Really move webcore.gyp & javascriptcore.gyp to webkit.org
* Create upstream copy of features.gypi and make downstream features.gypi inherit from it.

Previous step: 
http://codereview.chromium.org/212003
http://src.chromium.org/viewvc/chrome?view=rev&revision=26584

Committed: http://src.chromium.org/viewvc/chrome/trunk/26628

[yaar, 2009-09-18 20:33:19]

Mark, I appreciate your help.

http://codereview.chromium.org/208029/diff/1001/2001
File chrome/test/perf/url_parse_perftest.cc (right):

http://codereview.chromium.org/208029/diff/1001/2001#newcode20
Line 20: #ifdef USE_GOOGLE_URL_LIBRARY
USE_GOOGLE_URL_LIBRARY is no longer defined because nobody except this test is
ever using it.

http://codereview.chromium.org/208029/diff/1001/2002
File webkit/config.gyp (left):

http://codereview.chromium.org/208029/diff/1001/2002#oldcode40
Line 40: }
config target moved into javascriptcore.gyp:wtf_config which is only depended on
by wtf.

http://codereview.chromium.org/208029/diff/1001/2003
File webkit/features.gypi (left):

http://codereview.chromium.org/208029/diff/1001/2003#oldcode31
Line 31: 'BUILDING_CHROMIUM__=1',
moved to wtf_config

http://codereview.chromium.org/208029/diff/1001/2003#oldcode32
Line 32: 'USE_GOOGLE_URL_LIBRARY=1',
removed - nobody using it anywhere anymore

http://codereview.chromium.org/208029/diff/1001/2003#oldcode33
Line 33: 'USE_SYSTEM_MALLOC=1',
moved to wtf_config

http://codereview.chromium.org/208029/diff/1001/2003#oldcode34
Line 34: 'WEBCORE_NAVIGATOR_VENDOR="Google Inc."',
moved to webcore

http://codereview.chromium.org/208029/diff/1001/2003#oldcode43
Line 43: 'WEBCORE_NAVIGATOR_PLATFORM="Linux i686"',
moved to webcore

http://codereview.chromium.org/208029/diff/1001/2003#oldcode49
Line 49: 'BUILDING_ON_LEOPARD',
moved to wtf_config

http://codereview.chromium.org/208029/diff/1001/2003#oldcode52
Line 52: 
moved to webcore

http://codereview.chromium.org/208029/diff/1001/2003#oldcode74
Line 74: 
moved to webcore

http://codereview.chromium.org/208029/diff/1001/2003#oldcode76
Line 76: 'WTF_USE_NEW_THEME=1',
moved to wtf_config

http://codereview.chromium.org/208029/diff/1001/2003#oldcode81
Line 81: 'CRASH=__debugbreak',
moved to wtf_config

http://codereview.chromium.org/208029/diff/1001/2003#oldcode83
Line 83: 'WEBCORE_NAVIGATOR_PLATFORM="Win32"',
move to webcore

http://codereview.chromium.org/208029/diff/1001/2004
File webkit/javascriptcore.gyp (left):

http://codereview.chromium.org/208029/diff/1001/2004#oldcode73
Line 73: },
moved to wtf_config

http://codereview.chromium.org/208029/diff/1001/2004
File webkit/javascriptcore.gyp (right):

http://codereview.chromium.org/208029/diff/1001/2004#newcode24
Line 24: #
I will remove #

http://codereview.chromium.org/208029/diff/1001/2005
File webkit/webcore.gyp (left):

http://codereview.chromium.org/208029/diff/1001/2005#oldcode118
Line 118: '<@(feature_defines)',
inherited from wtf so no need to redefine

http://codereview.chromium.org/208029/diff/1001/2005#oldcode119
Line 119: '<@(non_feature_defines)',
doesn't exist any more

[Mark Mentovai, 2009-09-18 20:36:31]

Nice, can we get an answer to the USE_GOOGLE_URL_LIBRARY question?

http://codereview.chromium.org/208029/diff/1001/2001
File chrome/test/perf/url_parse_perftest.cc (right):

http://codereview.chromium.org/208029/diff/1001/2001#newcode20
Line 20: #ifdef USE_GOOGLE_URL_LIBRARY
> USE_GOOGLE_URL_LIBRARY is no longer defined because nobody except this test is
> ever using it.

If nobody ever defines it, then we don't ever need to undef it, right?

http://codereview.chromium.org/208029/diff/1001/2004
File webkit/javascriptcore.gyp (right):

http://codereview.chromium.org/208029/diff/1001/2004#newcode24
Line 24: #
> I will remove #

OK

[yaar, 2009-09-18 20:46:34]

I'm sorry about so many small patches. I'm still a bit clumsy with the tools.

[Mark Mentovai, 2009-09-18 21:20:12]

lgtm if it passes the trybots

[Ben Laurie (Chromium), 2009-09-23 21:42:26]

http://codereview.chromium.org/208029/diff/2007/2012
File webkit/webcore.gyp (right):

http://codereview.chromium.org/208029/diff/2007/2012#newcode119
Line 119: 'conditions': [
This duplicates the 'conditions' key below at line 578. One of them will hide
the other (found with the new --check flag, so proud).