Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 212003: Upstreamings parts of webkit.gyp (step 1) (Closed)

Created:
11 years, 3 months ago by yaar
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
yaar, dglazkov
Visibility:
Public.

Description

Upstreamings parts of webkit.gyp (step 1) This is step 1 a multi-step process that is part of the webkit chromium port. This step includes: A. Refactoring the wtf, pcre & webcore targets into separate files javascriptcore.gypi and webcore.gyp, which would eventually move upstream. B. Refactoring the feature_define variables into features.gypi, to allow two sets of feature defines - one for chromium port and one for chromium. C. Refactoring the config target into config.gyp, since currently both javascriptcore and webcore target depend on it. Next steps: 2. Eliminate config dependency. 3. Make features.gypi only override built-in variables that live upstream (so we don't have to maintain 2 parallel feature lists). 4. Really move webcore.gyp & javascriptcore.gyp to webkit.org Committed: http://src.chromium.org/viewvc/chrome/trunk/26584

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+967 lines, -911 lines) Patch
A webkit/config.gyp View 1 chunk +40 lines, -0 lines 1 comment Download
A webkit/features.gypi View 1 chunk +85 lines, -0 lines 0 comments Download
A webkit/javascriptcore.gyp View 1 chunk +122 lines, -0 lines 1 comment Download
M webkit/tools/test_shell/test_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download
A webkit/webcore.gyp View 1 chunk +715 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 4 chunks +4 lines, -910 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
yaar
Mark, this is only the 1st step of what we decided to do. I like ...
11 years, 3 months ago (2009-09-17 00:32:19 UTC) #1
Mark Mentovai
11 years, 3 months ago (2009-09-17 17:56:25 UTC) #2
LG

http://codereview.chromium.org/212003/diff/1/2
File webkit/config.gyp (right):

http://codereview.chromium.org/212003/diff/1/2#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
Remember to do a follow-up to set svn:eol-style if you're using git and it
doesn't set it for you.

http://codereview.chromium.org/212003/diff/1/4
File webkit/javascriptcore.gyp (right):

http://codereview.chromium.org/212003/diff/1/4#newcode70
Line 70: 'defines': ['WTF_USE_PTHREADS=1'],
Is this something that we want in features.gypi?

http://codereview.chromium.org/212003/diff/1/7
File webkit/webkit.gyp (right):

http://codereview.chromium.org/212003/diff/1/7#newcode7
Line 7: '../third_party/WebKit/WebCore/WebCore.gypi',
Is that a space at the end of the line?  Presubmit will hate that.

I don't know if there's a way to make presubmit run automatically when you're
using git.

Powered by Google App Engine
This is Rietveld 408576698