Issue 208028: Revert "Use a factory method to abstract SCMWrapper creation." totally broke gclient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208028: Revert "Use a factory method to abstract SCMWrapper creation." totally broke gclient. (Closed)

Created:
11 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert "Use a factory method to abstract SCMWrapper creation." totally broke gclient. TBR=msb TEST=none BUG=none

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -99 lines)			Patch
M	gclient.py	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	gclient_scm.py	View	3 chunks	+20 lines, -31 lines	0 comments	Download
M	tests/gclient_test.py	View	23 chunks	+63 lines, -64 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

msb

11 years, 3 months ago (2009-09-18 21:39:13 UTC) #2

lgtm

maruel@chromium.org (maruel@chromium.org) wrote:
> Reviewers: msb,
>
> Description:
> Revert "Use a factory method to abstract SCMWrapper creation." totally broke
> gclient.
>
> TBR=msb
> TEST=none
> BUG=none
>
> Please review this at http://codereview.chromium.org/208028
>
> Affected files:
>   M gclient.py
>   M gclient_scm.py
>   M tests/gclient_test.py
>
>

Expand Messages | Collapse Messages