Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 208023: Make extension shelf resize correctly with the window. (Closed)

Created:
11 years, 3 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, pink (ping after 24hrs)
Visibility:
Public.

Description

Make extension shelf resize correctly with the window. I just changed the shelf to autosize horizontally and to be anchored at the bottom and the left and right sides in IB (it was anchored to the top left before and had no autoresizing). BUG=none TEST=Enable extension shelf in browser_window_controller.mm (turn #if 0 into #if 1), then build & start chromium. Resize the browser window. The shelf should now stay at the bottom of the window and stay sane. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/nibs/ExtensionShelf.xib View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
Rohit: Please review. Yes, the whole line. Pink: FYI, since you reported this.
11 years, 3 months ago (2009-09-18 07:20:04 UTC) #1
rohitrao (ping after 24h)
11 years, 3 months ago (2009-09-18 15:01:06 UTC) #2
LGTM

(I also double-checked that the layoutSubviews logic in BWC looks good.)

On Fri, Sep 18, 2009 at 3:20 AM,  <thakis@chromium.org> wrote:
> Reviewers: rohitrao,
>
> Message:
> Rohit: Please review. Yes, the whole line.
> Pink: FYI, since you reported this.
>
> Description:
> Make extension shelf resize correctly with the window.
>
> I just changed the shelf to autosize horizontally and to be anchored at t=
he
> bottom and the left and right sides in IB (it was anchored to the top lef=
t
> before and had no autoresizing).
>
> BUG=3Dnone
> TEST=3DEnable extension shelf in browser_window_controller.mm (turn #if 0=
 into
> #if
> 1), then build & start chromium. Resize the browser window. The shelf sho=
uld
> now
> stay at the bottom of the window and stay sane.
>
> Please review this at http://codereview.chromium.org/208023
>
> Affected files:
> =A0M chrome/app/nibs/ExtensionShelf.xib
>
>
> Index: chrome/app/nibs/ExtensionShelf.xib
> diff --git a/chrome/app/nibs/ExtensionShelf.xib
> b/chrome/app/nibs/ExtensionShelf.xib
> index
> 19789c94e920fe596b8a3360bbc94e8597001622..d9216cd95e16271d80678066689e670=
6be010221
> 100644
> --- a/chrome/app/nibs/ExtensionShelf.xib
> +++ b/chrome/app/nibs/ExtensionShelf.xib
> @@ -36,7 +36,7 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</object>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<object class=3D"NSCustomV=
iew" id=3D"1005">
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<reference=
 key=3D"NSNextResponder"/>
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 <int key=3D=
"NSvFlags">268</int>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 <int key=3D=
"NSvFlags">290</int>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<string ke=
y=3D"NSFrameSize">{400, 30}</string>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<reference=
 key=3D"NSSuperview"/>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<string
> key=3D"NSClassName">DownloadShelfView</string>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698