Issue 2077017: Strip the subversion revision when passing it as an argument to --revision....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2077017: Strip the subversion revision when passing it as an argument to --revision.... (Closed)

Created:
10 years, 7 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Strip the subversion revision when passing it as an argument to --revision. Turns out svn treats extra whitespace as part of the revision number and throws an exception. BUG=44790 TEST=insert some spaces in your revision arguments, gclient should still work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47979

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	gclient_scm.py	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

10 years, 7 months ago (2010-05-21 20:47:32 UTC) #3

On 2010/05/21 20:47:15, Marc-Antoine Ruel wrote:
> lgtm

but I'm pretty sure git does the same.

Expand Messages | Collapse Messages