Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: gclient_scm.py

Issue 2077017: Strip the subversion revision when passing it as an argument to --revision.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
===================================================================
--- gclient_scm.py (revision 47950)
+++ gclient_scm.py (working copy)
@@ -1,4 +1,4 @@
-# Copyright (c) 2009 The Chromium Authors. All rights reserved.
+# Copyright (c) 2010 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -682,7 +682,7 @@
# We need to checkout.
command = ['checkout', url, checkout_path]
if revision:
- command.extend(['--revision', str(revision)])
+ command.extend(['--revision', str(revision).strip()])
scm.SVN.RunAndGetFileList(options, command, self._root_dir, file_list)
return
@@ -740,7 +740,7 @@
# We need to checkout.
command = ['checkout', url, checkout_path]
if revision:
- command.extend(['--revision', str(revision)])
+ command.extend(['--revision', str(revision).strip()])
scm.SVN.RunAndGetFileList(options, command, self._root_dir, file_list)
return
@@ -754,7 +754,7 @@
command = ["update", checkout_path]
if revision:
- command.extend(['--revision', str(revision)])
+ command.extend(['--revision', str(revision).strip()])
scm.SVN.RunAndGetFileList(options, command, self._root_dir, file_list)
def updatesingle(self, options, args, file_list):
@@ -783,7 +783,7 @@
command = ["export", os.path.join(self.url, filename),
os.path.join(checkout_path, filename)]
if options.revision:
- command.extend(['--revision', str(options.revision)])
+ command.extend(['--revision', str(options.revision).strip()])
scm.SVN.Run(command, self._root_dir)
def revert(self, options, args, file_list):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698