Issue 2076010: Try flattening strings before comparing for equality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2076010: Try flattening strings before comparing for equality. (Closed)

Created:
10 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Try flattening strings before comparing for equality. Committed: http://code.google.com/p/v8/source/detail?r=4684

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -43 lines)			Patch
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	2 chunks	+25 lines, -9 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+31 lines, -30 lines	1 comment	Download
M	src/objects-inl.h	View	1 chunk	+9 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 7 months ago (2010-05-19 12:27:43 UTC) #2

LGTM

http://codereview.chromium.org/2076010/diff/1/3
File src/objects-inl.h (right):

http://codereview.chromium.org/2076010/diff/1/3#newcode1694
src/objects-inl.h:1694: if (!StringShape(this).IsCons()) return this;
StringShapes should be deprecated, they were a failed optimization attempt.
Please just use IsConsString() here.

http://codereview.chromium.org/2076010/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/2076010/diff/1/4#newcode4590
src/objects.cc:4590: if (StringShape(lhs).IsSequentialAscii() &&
lhs->IsSeqAsciiString() and rhs->IsSeqAsciiString()

Expand Messages | Collapse Messages