src/heap.cc - Issue 2076010: Try flattening strings before comparing for equality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 2076010: Try flattening strings before comparing for equality. (Closed)

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index d33d91ab4ad8f8e85fca4609b69fa56b5b9f7097..d554a3ba684c10517bc6cbb2cd5620ebceef564c 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -2080,7 +2080,7 @@ Object* Heap::AllocateSubString(String* buffer,

}

// Make an attempt to flatten the buffer to reduce access time.

- buffer->TryFlatten();

+ buffer = buffer->TryFlattenGetString();

Object* result = buffer->IsAsciiRepresentation()

? AllocateRawAsciiString(length, pretenure )

« no previous file with comments | « no previous file | src/objects.h » ('j') | src/objects.cc » ('J')