Issue 2075010: X64: Make all arithmetic ops, and a few other, try to avoid rsp and r12 as base register.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2075010: X64: Make all arithmetic ops, and a few other, try to avoid rsp and r12 as base register. (Closed)

Created:
10 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Make all arithmetic ops, and a few other, try to avoid rsp and r12 as base register. Using rsp or r12 as the "base" register of the ModR/M byte forces a SIB byte, even with no index register. Some operations can avoid this by using another, equivalent, encoding that swaps the meaning of the base and register parts.

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -37 lines)			Patch
	M	src/x64/assembler-x64.h	View		2 chunks	+2 lines, -10 lines	0 comments	Download
	M	src/x64/assembler-x64.cc	View		8 chunks	+83 lines, -27 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 7 months ago (2010-05-18 13:32:01 UTC) #2

LGTM.  How about adding a comment, "Switch src and dst", in those places where
you do so.

Expand Messages | Collapse Messages