Fix reads and writes to freed memory in Channel::ChannelImpl::OnFileCanReadWi...

Fix reads and writes to freed memory in Channel::ChannelImpl::OnFileCanReadWithoutBlocking()
BUG=22451
TEST=valgrind should no longer report the freed write error in the UtilityProcessHostTest.ExtensionUnpacker test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27289

[jeremy, 2009-09-24 20:03:40]

Is this ready for review?

[hawk_google.com, 2009-09-24 20:06:48]

On Thu, Sep 24, 2009 at 1:03 PM,  <jeremy@chromium.org> wrote:
> Is this ready for review?
>
> http://codereview.chromium.org/207050

Yes indeedy.

Chris

[jeremy, 2009-09-24 20:09:17]

Awesome, thanks for digging to the bottom of this!

Could you include removal of the valgrind suppression as part of this CL?

[hawk, 2009-09-24 20:44:35]

On 2009/09/24 20:09:17, jeremy wrote:
> Awesome, thanks for digging to the bottom of this!

Thank goodness for printf!

> Could you include removal of the valgrind suppression as part of this CL?

Hmmm... I would, but I don't see in in either of the tool/valgrind/memcheck
suppression files. It's got to be in there, because this error is 100%
reproducible on my machine with no special compiler options (like those
specified in the bug report). Do you know which suppression it is? All of the
IPC channel related ones I see are leaks.

[jeremy, 2009-09-24 20:50:04]

LGTM

turns out there's no suppression for this so feel free to commit at will :)