Issue 207028: Fix build bustage caused by unintended changes being committed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207028: Fix build bustage caused by unintended changes being committed.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix build bustage caused by unintended changes being committed. TBR=jorlow BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26547

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	webkit/glue/webframeloaderclient_impl.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jorlow

11 years, 3 months ago (2009-09-18 04:27:31 UTC) #2

LGTM

On Thu, Sep 17, 2009 at 9:12 PM, <darin@chromium.org> wrote:

> Reviewers: Jeremy Orlow,
>
> Description:
> Fix build bustage caused by unintended changes being committed.
>
> TBR=jorlow
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/207028
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     webkit/glue/webframeloaderclient_impl.cc
>
>
> Index: webkit/glue/webframeloaderclient_impl.cc
> ===================================================================
> --- webkit/glue/webframeloaderclient_impl.cc    (revision 26546)
> +++ webkit/glue/webframeloaderclient_impl.cc    (working copy)
> @@ -35,7 +35,6 @@
>  #include "webkit/api/public/WebFrameClient.h"
>  #include "webkit/api/public/WebPlugin.h"
>  #include "webkit/api/public/WebPluginParams.h"
> -#include "webkit/api/public/WebSecurityOrigin.h"
>  #include "webkit/api/public/WebURL.h"
>  #include "webkit/api/public/WebURLError.h"
>  #include "webkit/api/public/WebVector.h"
> @@ -988,7 +987,7 @@
>  void WebFrameLoaderClient::didRunInsecureContent(SecurityOrigin* origin) {
>   if (webframe_->client()) {
>     webframe_->client()->didRunInsecureContent(webframe_,
> -        webkit_glue::SecurityOriginToWebSecurityOrigin(origin));
> +        webkit_glue::StringToWebString(origin->toString()));
>   }
>  }
>
>
>
>

Expand Messages | Collapse Messages