Issue 207002: Fixed Chrome implementation of worker error reporting to report errors via ev...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207002: Fixed Chrome implementation of worker error reporting to report errors via ev... (Closed)

Created:
11 years, 3 months ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
levin

CC:
chromium-reviews_googlegroups.com, jam, darin (slow to review), pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed Chrome implementation of worker error reporting to report errors via event listeners, not just via onerror. Rebaselined worker-script-error test to reflect new test case. Re-enabled WorkerFastLayoutTests. BUG=20822 TEST=none (enabling existing tests)

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	chrome/worker/worker_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/workers/worker-script-error-expected.txt	View	1 chunk	+11 lines, -10 lines	0 comments	Download
M	webkit/glue/webworkerclient_impl.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

This turns back on all the existing WorkerFastLayoutTests.

11 years, 3 months ago (2009-09-16 22:16:23 UTC) #1

LGTM

Expand Messages | Collapse Messages