webkit/glue/webworkerclient_impl.cc - Issue 207002: Fixed Chrome implementation of worker error reporting to report errors via ev...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webworkerclient_impl.cc

Issue 207002: Fixed Chrome implementation of worker error reporting to report errors via ev... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/workers/worker-script-error-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/glue/webworkerclient_impl.cc

===================================================================

--- webkit/glue/webworkerclient_impl.cc (revision 26311)

+++ webkit/glue/webworkerclient_impl.cc (working copy)

@@ -237,11 +237,10 @@

}

bool handled = false;

- if (worker_->onerror())

- handled = worker_->dispatchScriptErrorEvent(

- webkit_glue::WebStringToString(error_message),

- webkit_glue::WebStringToString(source_url),

- line_number);

+ handled = worker_->dispatchScriptErrorEvent(

+ webkit_glue::WebStringToString(error_message),

+ webkit_glue::WebStringToString(source_url),

+ line_number);

if (!handled)

script_execution_context_->reportException(

webkit_glue::WebStringToString(error_message),

@@ -359,7 +358,7 @@

int line_number,

const WebCore::String& source_url) {

bool handled = false;

- if (this_ptr->worker_ && this_ptr->worker_->onerror())

+ if (this_ptr->worker_)

handled = this_ptr->worker_->dispatchScriptErrorEvent(

error_message, source_url, line_number);

if (!handled)

« no previous file with comments | « webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/workers/worker-script-error-expected.txt ('k') | no next file » | no next file with comments »