Use -DNDEBUG in non-debug builds to suppress debug warnings. Add gmock.

Use -DNDEBUG in non-debug builds to suppress debug warnings. Add gmock.

[petkov, 2010-05-11 19:56:55]

Related CL: http://codereview.chromium.org/2049007

[kmixter1, 2010-05-12 03:05:25]

Why aren't gmock and gtest RDEPENDs?

On Tue, May 11, 2010 at 12:56 PM,  <petkov@chromium.org> wrote:
> Reviewers: sosa, kmixter1,
>
> Message:
> Related CL: http://codereview.chromium.org/2049007
>
>
> Description:
> Use -DNDEBUG in non-debug builds to suppress debug warnings. Add gmock.
>
> Please review this at http://codereview.chromium.org/2055013/show
>
> SVN Base: ssh://git@chromiumos-git/chromiumos-overlay.git
>
> Affected files:
>  A + chromeos-base/metrics/metrics-0.0.1-r7.ebuild
>  M chromeos-base/metrics/metrics-0.0.1.ebuild
>
>
> Index: chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> diff --git a/chromeos-base/metrics/metrics-0.0.1-r6.ebuild
> b/chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> similarity index 100%
> rename from chromeos-base/metrics/metrics-0.0.1-r6.ebuild
> rename to chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> Index: chromeos-base/metrics/metrics-0.0.1.ebuild
> diff --git a/chromeos-base/metrics/metrics-0.0.1.ebuild
> b/chromeos-base/metrics/metrics-0.0.1.ebuild
> index
>
c151acc72f01eea38aabe758dfb83cb88669712a..93fb87648afb97c1200b6984ab55d2a21777e297
> 100644
> --- a/chromeos-base/metrics/metrics-0.0.1.ebuild
> +++ b/chromeos-base/metrics/metrics-0.0.1.ebuild
> @@ -3,7 +3,7 @@
>
>  EAPI=2
>
> -inherit toolchain-funcs
> +inherit flag-o-matic toolchain-funcs
>
>  DESCRIPTION="Chrome OS Metrics Collection Utilities"
>  HOMEPAGE="http://src.chromium.org"
> @@ -11,20 +11,23 @@ SRC_URI=""
>  LICENSE="BSD"
>  SLOT="0"
>  KEYWORDS="amd64 x86 arm"
> -IUSE=""
> +IUSE="debug test"
>
>  # TODO(petkov): Remove dependences on metrics_collection and metrics_daemon
>  # and the empty ebuilds once the build dust settles.
>  RDEPEND="chromeos-base/chromeos-metrics_collection
>        chromeos-base/chromeos-metrics_daemon
>        chromeos-base/libchrome
> +       dev-cpp/gflags
>        >=dev-libs/glib-2.0
>        dev-libs/dbus-glib
> -       sys-apps/dbus"
> +       sys-apps/dbus
> +       "
>
> -DEPEND="dev-cpp/gflags
> -       dev-cpp/gtest
> -       ${RDEPEND}"
> +DEPEND="${RDEPEND}
> +       test? ( dev-cpp/gmock )
> +       test? ( dev-cpp/gtest )
> +       "
>
>  src_unpack() {
>        local metrics="${CHROMEOS_ROOT}/src/platform/metrics"
> @@ -33,6 +36,7 @@ src_unpack() {
>  }
>
>  src_compile() {
> +       use debug || append-flags -DNDEBUG
>        tc-export CXX AR PKG_CONFIG
>        emake || die "metrics compile failed."
>  }
>
>
>

[petkov, 2010-05-12 04:26:42]

On Tue, May 11, 2010 at 8:05 PM, Ken Mixter <kmixter@chromium.org> wrote:

> Why aren't gmock and gtest RDEPENDs?
>

I haven't seen an ebuild that makes gtest/gmock RDEPEND (other than the
crash-reporter). They don't really need to be because we don't run unit
tests on the target -- so they don't need to be present on the target.
They're conditional on the "test" USE flag now, off by default, so it won't
hurt to make them RDEPENDs, I guess -- just in case we happen to run the
tests on the target in the distant future.


>
> On Tue, May 11, 2010 at 12:56 PM,  <petkov@chromium.org> wrote:
> > Reviewers: sosa, kmixter1,
> >
> > Message:
> > Related CL: http://codereview.chromium.org/2049007
> >
> >
> > Description:
> > Use -DNDEBUG in non-debug builds to suppress debug warnings. Add gmock.
> >
> > Please review this at http://codereview.chromium.org/2055013/show
> >
> > SVN Base: ssh://git@chromiumos-git/chromiumos-overlay.git
> >
> > Affected files:
> >  A + chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> >  M chromeos-base/metrics/metrics-0.0.1.ebuild
> >
> >
> > Index: chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> > diff --git a/chromeos-base/metrics/metrics-0.0.1-r6.ebuild
> > b/chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> > similarity index 100%
> > rename from chromeos-base/metrics/metrics-0.0.1-r6.ebuild
> > rename to chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> > Index: chromeos-base/metrics/metrics-0.0.1.ebuild
> > diff --git a/chromeos-base/metrics/metrics-0.0.1.ebuild
> > b/chromeos-base/metrics/metrics-0.0.1.ebuild
> > index
> >
>
c151acc72f01eea38aabe758dfb83cb88669712a..93fb87648afb97c1200b6984ab55d2a21777e297
> > 100644
> > --- a/chromeos-base/metrics/metrics-0.0.1.ebuild
> > +++ b/chromeos-base/metrics/metrics-0.0.1.ebuild
> > @@ -3,7 +3,7 @@
> >
> >  EAPI=2
> >
> > -inherit toolchain-funcs
> > +inherit flag-o-matic toolchain-funcs
> >
> >  DESCRIPTION="Chrome OS Metrics Collection Utilities"
> >  HOMEPAGE="http://src.chromium.org"
> > @@ -11,20 +11,23 @@ SRC_URI=""
> >  LICENSE="BSD"
> >  SLOT="0"
> >  KEYWORDS="amd64 x86 arm"
> > -IUSE=""
> > +IUSE="debug test"
> >
> >  # TODO(petkov): Remove dependences on metrics_collection and
> metrics_daemon
> >  # and the empty ebuilds once the build dust settles.
> >  RDEPEND="chromeos-base/chromeos-metrics_collection
> >        chromeos-base/chromeos-metrics_daemon
> >        chromeos-base/libchrome
> > +       dev-cpp/gflags
> >        >=dev-libs/glib-2.0
> >        dev-libs/dbus-glib
> > -       sys-apps/dbus"
> > +       sys-apps/dbus
> > +       "
> >
> > -DEPEND="dev-cpp/gflags
> > -       dev-cpp/gtest
> > -       ${RDEPEND}"
> > +DEPEND="${RDEPEND}
> > +       test? ( dev-cpp/gmock )
> > +       test? ( dev-cpp/gtest )
> > +       "
> >
> >  src_unpack() {
> >        local metrics="${CHROMEOS_ROOT}/src/platform/metrics"
> > @@ -33,6 +36,7 @@ src_unpack() {
> >  }
> >
> >  src_compile() {
> > +       use debug || append-flags -DNDEBUG
> >        tc-export CXX AR PKG_CONFIG
> >        emake || die "metrics compile failed."
> >  }
> >
> >
> >
>

[petkov, 2010-05-12 14:37:07]

On 2010/05/12 03:05:25, kmixter1 wrote:
> Why aren't gmock and gtest RDEPENDs?

I made them RDEPENDs -- because they really are. PTAL.

> 
> On Tue, May 11, 2010 at 12:56 PM,  <mailto:petkov@chromium.org> wrote:
> > Reviewers: sosa, kmixter1,
> >
> > Message:
> > Related CL: http://codereview.chromium.org/2049007
> >
> >
> > Description:
> > Use -DNDEBUG in non-debug builds to suppress debug warnings. Add gmock.
> >
> > Please review this at http://codereview.chromium.org/2055013/show
> >
> > SVN Base: ssh://git@chromiumos-git/chromiumos-overlay.git
> >
> > Affected files:
> > &nbsp;A + chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> > &nbsp;M chromeos-base/metrics/metrics-0.0.1.ebuild
> >
> >
> > Index: chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> > diff --git a/chromeos-base/metrics/metrics-0.0.1-r6.ebuild
> > b/chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> > similarity index 100%
> > rename from chromeos-base/metrics/metrics-0.0.1-r6.ebuild
> > rename to chromeos-base/metrics/metrics-0.0.1-r7.ebuild
> > Index: chromeos-base/metrics/metrics-0.0.1.ebuild
> > diff --git a/chromeos-base/metrics/metrics-0.0.1.ebuild
> > b/chromeos-base/metrics/metrics-0.0.1.ebuild
> > index
> >
>
c151acc72f01eea38aabe758dfb83cb88669712a..93fb87648afb97c1200b6984ab55d2a21777e297
> > 100644
> > --- a/chromeos-base/metrics/metrics-0.0.1.ebuild
> > +++ b/chromeos-base/metrics/metrics-0.0.1.ebuild
> > @@ -3,7 +3,7 @@
> >
> > &nbsp;EAPI=2
> >
> > -inherit toolchain-funcs
> > +inherit flag-o-matic toolchain-funcs
> >
> > &nbsp;DESCRIPTION="Chrome OS Metrics Collection Utilities"
> > &nbsp;HOMEPAGE="http://src.chromium.org"
> > @@ -11,20 +11,23 @@ SRC_URI=""
> > &nbsp;LICENSE="BSD"
> > &nbsp;SLOT="0"
> > &nbsp;KEYWORDS="amd64 x86 arm"
> > -IUSE=""
> > +IUSE="debug test"
> >
> > &nbsp;# TODO(petkov): Remove dependences on metrics_collection and
metrics_daemon
> > &nbsp;# and the empty ebuilds once the build dust settles.
> > &nbsp;RDEPEND="chromeos-base/chromeos-metrics_collection
> > &nbsp; &nbsp; &nbsp; &nbsp;chromeos-base/chromeos-metrics_daemon
> > &nbsp; &nbsp; &nbsp; &nbsp;chromeos-base/libchrome
> > + &nbsp; &nbsp; &nbsp; dev-cpp/gflags
> > &nbsp; &nbsp; &nbsp; &nbsp;>=dev-libs/glib-2.0
> > &nbsp; &nbsp; &nbsp; &nbsp;dev-libs/dbus-glib
> > - &nbsp; &nbsp; &nbsp; sys-apps/dbus"
> > + &nbsp; &nbsp; &nbsp; sys-apps/dbus
> > + &nbsp; &nbsp; &nbsp; "
> >
> > -DEPEND="dev-cpp/gflags
> > - &nbsp; &nbsp; &nbsp; dev-cpp/gtest
> > - &nbsp; &nbsp; &nbsp; ${RDEPEND}"
> > +DEPEND="${RDEPEND}
> > + &nbsp; &nbsp; &nbsp; test? ( dev-cpp/gmock )
> > + &nbsp; &nbsp; &nbsp; test? ( dev-cpp/gtest )
> > + &nbsp; &nbsp; &nbsp; "
> >
> > &nbsp;src_unpack() {
> > &nbsp; &nbsp; &nbsp; &nbsp;local
metrics="${CHROMEOS_ROOT}/src/platform/metrics"
> > @@ -33,6 +36,7 @@ src_unpack() {
> > &nbsp;}
> >
> > &nbsp;src_compile() {
> > + &nbsp; &nbsp; &nbsp; use debug || append-flags -DNDEBUG
> > &nbsp; &nbsp; &nbsp; &nbsp;tc-export CXX AR PKG_CONFIG
> > &nbsp; &nbsp; &nbsp; &nbsp;emake || die "metrics compile failed."
> > &nbsp;}
> >
> >
> >
>

[petkov, 2010-05-12 17:33:45]

PTAL. Back to unconditional DEPENDs for gmock/gtest because of
gtest/gtest_prod.h.

Theoretically they also need to be RDEPENDs but we don't want them on the image
for now.

The whole unit test buildbot system is broken now because build_tests.sh doesn't
set the "test" use flag. So gmock/gtest get built by accident.

[sosa, 2010-05-12 18:09:47]

LGTM.  Agreed unittests are broken right now and we don't have a clear
methodology for it.  I've filed an issue so that we can track addressing it.

http://code.google.com/p/chromium-os/issues/detail?id=3229