Start transition the metrics library to non-static API. Use gmock in tests.

Start transition the metrics library to non-static API. Use gmock in tests.

[petkov, 2010-05-11 19:56:20]

Related CL: http://codereview.chromium.org/2055013

[kmixter, 2010-05-12 05:15:43]

LGTM with nits

http://codereview.chromium.org/2049007/diff/6001/7004
File src/platform/metrics/metrics_daemon.h (right):

http://codereview.chromium.org/2049007/diff/6001/7004#newcode118
src/platform/metrics/metrics_daemon.h:118: void Init(bool testing,
MetricsLibraryInterface* metrics_lib_);
you don't want that final underscore

http://codereview.chromium.org/2049007/diff/6001/7005
File src/platform/metrics/metrics_daemon_test.cc (right):

http://codereview.chromium.org/2049007/diff/6001/7005#newcode209
src/platform/metrics/metrics_daemon_test.cc:209: CheckpointMetricExpectations();
I don't use gmock all that much, but I think the pattern I've seen is to make
every one of these sections its own test so that the mock is created and
destroyed and destruction I think checkpoints expectations.  If you want to
group those tests more, you can always create an empty fixture class which
derives from MetricsDaemonTest.

[petkov, 2010-05-12 15:05:55]

Thanks for the review. Comments addressed.

http://codereview.chromium.org/2049007/diff/6001/7004
File src/platform/metrics/metrics_daemon.h (right):

http://codereview.chromium.org/2049007/diff/6001/7004#newcode118
src/platform/metrics/metrics_daemon.h:118: void Init(bool testing,
MetricsLibraryInterface* metrics_lib_);
On 2010/05/12 05:15:43, kmixter wrote:
> you don't want that final underscore

Done.

http://codereview.chromium.org/2049007/diff/6001/7005
File src/platform/metrics/metrics_daemon_test.cc (right):

http://codereview.chromium.org/2049007/diff/6001/7005#newcode209
src/platform/metrics/metrics_daemon_test.cc:209: CheckpointMetricExpectations();
On 2010/05/12 05:15:43, kmixter wrote:
> I don't use gmock all that much, but I think the pattern I've seen is to make
> every one of these sections its own test so that the mock is created and
> destroyed and destruction I think checkpoints expectations.  If you want to
> group those tests more, you can always create an empty fixture class which
> derives from MetricsDaemonTest.

The checkpoint call is in the gmock cookbook. However, it makes sense to break
down the tests into simpler tests anyway so I've done that thus eliminating the
need for checkpointing.

[sosa, 2010-05-12 18:01:05]

the reworking of checkpoint lgtm (and also the rest)