Issue 2053001: Fix crash when opening "Select certificate file" in OOBE.

Issue 2053001: Fix crash when opening "Select certificate file" in OOBE. (Closed)

Created:
10 years, 7 months ago by Nikita (slow)

Modified:
9 years, 7 months ago

Reviewers:
whywhat, DaveMoore, Nathan Williams, Charlie Lee

CC:
chromium-os-reviews_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, nkostylev+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix crash when opening "Select certificate file" in OOBE. Pass default profile and correct top window in OOBE. BUG=http://crosbug.com/2978 TEST=On welcome screen select encrypted 802.1X network and open "select certificate" dialog. It should open withot crash. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=47125

Patch Set 1 #

Patch Set 2 : pass correct parent window #

Patch Set 3 : pass correct parent window for OOBE only #

Patch Set 4 : delete commented code #

Patch Set 5 : added correct way to check for OOBE/login mode #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -13 lines)			Patch
M	chrome/browser/chromeos/frame/browser_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/frame/browser_view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/background_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen.cc	View	3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_config_view.h	View	1 2 3 4	3 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_config_view.cc	View	1 2 3 4	2 chunks	+15 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.cc	View	2 3 4	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View		5 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/status_area_host.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/shell_dialogs.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/browser_dialogs.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/html_dialog_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/select_file_dialog.cc	View	1 2 3 4	6 chunks	+37 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Quick fix, added TODO to figure out better way detecting OOBE mode. In OOBE mode ...

10 years, 7 months ago (2010-05-07 18:56:44 UTC) #1

Nikita (slow)

Please take another look. I've added the correct way to detect browser vs OOBE/login mode. ...

10 years, 7 months ago (2010-05-12 14:17:37 UTC) #3

whywhat

LGTM I'd add Charlie to reviewers list as he asked to do so when touching ...

10 years, 7 months ago (2010-05-12 14:53:38 UTC) #4

Expand Messages | Collapse Messages