chrome/browser/views/html_dialog_view.cc - Issue 2053001: Fix crash when opening "Select certificate file" in OOBE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/html_dialog_view.cc

Issue 2053001: Fix crash when opening "Select certificate file" in OOBE. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: added correct way to check for OOBE/login mode Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/html_dialog_view.cc

diff --git a/chrome/browser/views/html_dialog_view.cc b/chrome/browser/views/html_dialog_view.cc

index ccf1423b2634cb55533ab5ce88de47282720e7cb..68a2c8058b728455c653e0e5dbce5415c611361e 100644

--- a/chrome/browser/views/html_dialog_view.cc

+++ b/chrome/browser/views/html_dialog_view.cc

@@ -14,10 +14,10 @@

namespace browser {

// Declared in browser_dialogs.h so that others don't need to depend on our .h.

-void ShowHtmlDialogView(gfx::NativeWindow parent, Browser* browser,

+void ShowHtmlDialogView(gfx::NativeWindow parent, Profile* profile,

HtmlDialogUIDelegate* delegate) {

HtmlDialogView* html_view =

- new HtmlDialogView(browser->profile(), delegate);

+ new HtmlDialogView(profile, delegate);

views::Window::CreateChromeWindow(parent, gfx::Rect(), html_view);

html_view->InitDialog();

html_view->window()->Show();