Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 20491: Add host callback for debug break.... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add host callback for debug break. Add the ability to have the host embedding V8 receive a callback in the V8 thread while V8 is processing a debug callback. When V8 is processing a debug callback the thread where V8 is executing is sitting in a tight loop processing debug commands until the continue command has been executed. In some embedding situations it is beneficial to be able to call back into the embedding host from the thread where V8 is sitting. The might have functions which needs to be called to complement the JavaScript debugging. Using the uint16_t array to pass a void* is a temporary hack. Committed: http://code.google.com/p/v8/source/detail?r=1318

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -10 lines) Patch
M include/v8-debug.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/debug.h View 3 chunks +10 lines, -2 lines 1 comment Download
M src/debug.cc View 6 chunks +45 lines, -8 lines 1 comment Download
M test/cctest/test-debug.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
LGTM
11 years, 10 months ago (2009-02-19 13:35:51 UTC) #1
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-19 13:43:55 UTC) #2
Mads Ager (chromium)
LGTM Passing the void* as two uint16_t values *is* a hack...
11 years, 10 months ago (2009-02-19 13:48:28 UTC) #3
yurys
11 years, 10 months ago (2009-02-19 14:44:18 UTC) #4
LGTM

http://codereview.chromium.org/20491/diff/1/6
File src/debug.cc (right):

http://codereview.chromium.org/20491/diff/1/6#newcode1936
Line 1936: Debugger::host_dispatch_handler_(reinterpret_cast<void*>(dispatch),
why not just call dispatch with some dispatch data without this indirection?

http://codereview.chromium.org/20491/diff/1/5
File src/debug.h (right):

http://codereview.chromium.org/20491/diff/1/5#newcode422
Line 422: friend class DebugMessageThread;
wrong indentation

Powered by Google App Engine
This is Rietveld 408576698