Added teartest UI.

Added teartest UI.

[Alexey Marinichev, 2010-05-06 22:40:15]

This was inspired by the bluetooth test.
I'm not a UI person, nor am I an HTML person.

[piman, 2010-05-10 19:41:56]

http://codereview.chromium.org/2047001/diff/1/4
File client/site_tests/graphics_TearTest/graphics_TearTest.py (right):

http://codereview.chromium.org/2047001/diff/1/4#newcode74
client/site_tests/graphics_TearTest/graphics_TearTest.py:74: break
Why early-exit here ? Don't we want to run all tests always ? That can provide
more data to help debugging the issue.

[Alexey Marinichev, 2010-05-10 19:49:04]

http://codereview.chromium.org/2047001/diff/1/4
File client/site_tests/graphics_TearTest/graphics_TearTest.py (right):

http://codereview.chromium.org/2047001/diff/1/4#newcode74
client/site_tests/graphics_TearTest/graphics_TearTest.py:74: break
On 2010/05/10 19:41:56, piman wrote:
> Why early-exit here ? Don't we want to run all tests always ? That can provide
> more data to help debugging the issue.
I was thinking it would make running the test quicker. Manual tests are always
tedious. Besides, debugging would probably be done running the test directly
from the command line or something.
I can add a "Done" button and maybe a summary screen?

[piman, 2010-05-10 19:57:09]

I also figured a more straightforward process (exactly 3 tests) is less
human-error-prone than a more complex one (3 tests except if one fails).
But LGTM either way, I don't have a strong opinion (maybe someone does).

[petkov, 2010-05-10 23:13:55]

http://codereview.chromium.org/2047001/diff/1/4
File client/site_tests/graphics_TearTest/graphics_TearTest.py (right):

http://codereview.chromium.org/2047001/diff/1/4#newcode7
client/site_tests/graphics_TearTest/graphics_TearTest.py:7: import os, time
os imported twice. time is not used? remove if so. same with re.

http://codereview.chromium.org/2047001/diff/1/4#newcode9
client/site_tests/graphics_TearTest/graphics_TearTest.py:9: from
autotest_lib.client.common_lib import site_ui, error, utils
sort

http://codereview.chromium.org/2047001/diff/1/4#newcode31
client/site_tests/graphics_TearTest/graphics_TearTest.py:31: def run_once(self):
two empty lines between methods, per CODING_STYLE

http://codereview.chromium.org/2047001/diff/1/4#newcode41
client/site_tests/graphics_TearTest/graphics_TearTest.py:41: 'DISPLAY=:0
XAUTHORITY=/home/chronos/.Xauthority ' +
Use site_ui.xcommand?

http://codereview.chromium.org/2047001/diff/1/4#newcode78
client/site_tests/graphics_TearTest/graphics_TearTest.py:78: if result is None:
You should probably put these conditions (None and Fail) inside the loop above
-- this way you can include in the exception string which test failed.

[Alexey Marinichev, 2010-05-11 19:10:06]

http://codereview.chromium.org/2047001/diff/1/4
File client/site_tests/graphics_TearTest/graphics_TearTest.py (right):

http://codereview.chromium.org/2047001/diff/1/4#newcode7
client/site_tests/graphics_TearTest/graphics_TearTest.py:7: import os, time
On 2010/05/10 23:13:55, petkov wrote:
> os imported twice. time is not used? remove if so. same with re.
> 
> 
> 

Done.

http://codereview.chromium.org/2047001/diff/1/4#newcode9
client/site_tests/graphics_TearTest/graphics_TearTest.py:9: from
autotest_lib.client.common_lib import site_ui, error, utils
On 2010/05/10 23:13:55, petkov wrote:
> sort
> 

Done.

http://codereview.chromium.org/2047001/diff/1/4#newcode31
client/site_tests/graphics_TearTest/graphics_TearTest.py:31: def run_once(self):
On 2010/05/10 23:13:55, petkov wrote:
> two empty lines between methods, per CODING_STYLE
> 

Done.

http://codereview.chromium.org/2047001/diff/1/4#newcode41
client/site_tests/graphics_TearTest/graphics_TearTest.py:41: 'DISPLAY=:0
XAUTHORITY=/home/chronos/.Xauthority ' +
On 2010/05/10 23:13:55, petkov wrote:
> Use site_ui.xcommand?
> 

Done.

http://codereview.chromium.org/2047001/diff/1/4#newcode74
client/site_tests/graphics_TearTest/graphics_TearTest.py:74: break
On 2010/05/10 19:41:56, piman wrote:
> Why early-exit here ? Don't we want to run all tests always ? That can provide
> more data to help debugging the issue.

Done.

http://codereview.chromium.org/2047001/diff/1/4#newcode78
client/site_tests/graphics_TearTest/graphics_TearTest.py:78: if result is None:
On 2010/05/10 23:13:55, petkov wrote:
> You should probably put these conditions (None and Fail) inside the loop above
> -- this way you can include in the exception string which test failed.
> 

Done.

[petkov, 2010-05-11 20:51:45]

lgtm (although the code logic is a bit convoluted -- maybe comments will help).

Btw, who runs this test and when? As is, it's an orphaned test.