Issue 204028: Fix Snow Leopard SDK errors

Issue 204028: Fix Snow Leopard SDK errors (Closed)

Created:
11 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix Snow Leopard SDK errors error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument passing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26304

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/cocoa/autocomplete_text_field_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 3 months ago (2009-09-16 00:07:26 UTC) #2

LGTM

On Tue, Sep 15, 2009 at 7:00 PM,  <mark@chromium.org> wrote:
> Reviewers: rohitrao,
>
> Description:
> Fix Snow Leopard SDK errors
>
> error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument
> passing
>
> Please review this at http://codereview.chromium.org/204028
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
> =A0M =A0 =A0 chrome/browser/cocoa/autocomplete_text_field_unittest.mm
>
>
> Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/autocomplete/autocomplete_edit_view_mac.mm =A0 (revisi=
on
> 26272)
> +++ chrome/browser/autocomplete/autocomplete_edit_view_mac.mm =A0 (workin=
g
> copy)
> @@ -157,7 +157,7 @@
> =A0 DCHECK(profile);
> =A0 DCHECK(command_updater);
> =A0 DCHECK(field);
> - =A0[field_ setDelegate:edit_helper_];
> + =A0[field_ setDelegate:edit_helper_.get()];
>
> =A0 // Needed so that editing doesn't lose the styling.
> =A0 [field_ setAllowsEditingTextAttributes:YES];
> Index: chrome/browser/cocoa/autocomplete_text_field_unittest.mm
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/cocoa/autocomplete_text_field_unittest.mm =A0 =A0(revi=
sion
> 26272)
> +++ chrome/browser/cocoa/autocomplete_text_field_unittest.mm =A0 =A0(work=
ing
> copy)
> @@ -46,7 +46,7 @@
>
> =A0 =A0 window_delegate_.reset(
> =A0 =A0 =A0 =A0 [[AutocompleteTextFieldWindowTestDelegate alloc] init]);
> - =A0 =A0[cocoa_helper_.window() setDelegate:window_delegate_];
> + =A0 =A0[cocoa_helper_.window() setDelegate:window_delegate_.get()];
> =A0 }
>
> =A0 // The removeFromSuperview call is needed to prevent crashes in later
> tests.
>
>
>

Expand Messages | Collapse Messages