ExtensionShelf now uses the BookmarkExtensionBackground, just like the Bookma...

ExtensionShelf now uses the BookmarkExtensionBackground, just like the BookmarkBarView. 

Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. 
Added an interface that both BookmarkBarView and ExtensionShelf implement. 
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. 
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). 
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. 
Toolstrip text color values are no longer hard-coded but use the color specified in the theme. 
Decreased the timeouts for showing and hiding the toolstrip handle. 
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. 

Known issues: 

Some themes expose the fact that: 
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. 
- Didn't spend much time theming the shelf handle (just used the solid color from the theme). 
- When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change).

BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26227

[Finnur, 2009-09-15 17:07:38]

This is a changelist that is identical to the previous one
(http://codereview.chromium.org/203034, already LG'ed) except with a two line
change to the gyp file to make it build right on the Toolkit builder (LGed by
Jay).

[Scott Hess - ex-Googler, 2009-09-15 17:17:37]

On 2009/09/15 17:07:38, Finnur wrote:
> This is a changelist that is identical to the previous one
> (http://codereview.chromium.org/203034, already LG'ed) except with a two line
> change to the gyp file to make it build right on the Toolkit builder (LGed by
> Jay).

Is detachable_toolbar_view.h missing?

[Finnur, 2009-09-15 17:20:03]

Fix in.

On Tue, Sep 15, 2009 at 10:17, <shess@chromium.org> wrote:

> On 2009/09/15 17:07:38, Finnur wrote:
>
>> This is a changelist that is identical to the previous one
>> (http://codereview.chromium.org/203034, already LG'ed) except with a two
>> line
>> change to the gyp file to make it build right on the Toolkit builder (LGed
>> by
>> Jay).
>>
>
> Is detachable_toolbar_view.h missing?
>
>
> http://codereview.chromium.org/204022
>

[Erik does not do reviews, 2009-09-15 17:59:23]

gyp change LGTM