Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: content/browser/download/save_package_unittest.cc

Issue 2032283002: Remove refcounting from SavePackage. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_package_unittest.cc
diff --git a/content/browser/download/save_package_unittest.cc b/content/browser/download/save_package_unittest.cc
index c426772a8205db1ca1e0663c81b704a0d2a469dd..2cfc69c30285c379d2d4e7ad0db3c486804e1c06 100644
--- a/content/browser/download/save_package_unittest.cc
+++ b/content/browser/download/save_package_unittest.cc
@@ -5,6 +5,7 @@
#include <stddef.h>
#include <stdint.h>
+#include <memory>
#include <string>
#include "base/files/file_path.h"
@@ -105,9 +106,9 @@ class SavePackageTest : public RenderViewHostImplTestHarness {
// RenderViewHostImplTestHarness::SetUp.
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- save_package_success_ = new SavePackage(contents(),
- temp_dir_.path().AppendASCII("testfile" HTML_EXTENSION),
- temp_dir_.path().AppendASCII("testfile_files"));
+ save_package_success_ = base::WrapUnique(new SavePackage(
+ contents(), temp_dir_.path().AppendASCII("testfile" HTML_EXTENSION),
+ temp_dir_.path().AppendASCII("testfile_files")));
// We need to construct a path that is *almost* kMaxFilePathLength long
long_file_name.reserve(kMaxFilePathLength + long_file_name.length());
@@ -116,16 +117,17 @@ class SavePackageTest : public RenderViewHostImplTestHarness {
long_file_name.resize(
kMaxFilePathLength - 9 - temp_dir_.path().value().length());
- save_package_fail_ = new SavePackage(contents(),
+ save_package_fail_ = base::WrapUnique(new SavePackage(
+ contents(),
temp_dir_.path().AppendASCII(long_file_name + HTML_EXTENSION),
- temp_dir_.path().AppendASCII(long_file_name + "_files"));
+ temp_dir_.path().AppendASCII(long_file_name + "_files")));
}
private:
// SavePackage for successfully generating file name.
- scoped_refptr<SavePackage> save_package_success_;
+ std::unique_ptr<SavePackage> save_package_success_;
// SavePackage for failed generating file name.
- scoped_refptr<SavePackage> save_package_fail_;
+ std::unique_ptr<SavePackage> save_package_fail_;
base::ScopedTempDir temp_dir_;
};
@@ -400,7 +402,7 @@ static const struct SuggestedSaveNameTestCase {
#endif
TEST_F(SavePackageTest, MAYBE_TestSuggestedSaveNames) {
for (size_t i = 0; i < arraysize(kSuggestedSaveNames); ++i) {
- scoped_refptr<SavePackage> save_package(
+ std::unique_ptr<SavePackage> save_package(
new SavePackage(contents(), base::FilePath(), base::FilePath()));
save_package->page_url_ = GURL(kSuggestedSaveNames[i].page_url);
save_package->title_ = kSuggestedSaveNames[i].page_title;

Powered by Google App Engine
This is Rietveld 408576698