Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: content/browser/download/save_package_browsertest.cc

Issue 2032283002: Remove refcounting from SavePackage. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_package_browsertest.cc
diff --git a/content/browser/download/save_package_browsertest.cc b/content/browser/download/save_package_browsertest.cc
index cca77cf4ac8c2401960ca7f8ecfac610c7ef9fc4..c9d233c96a915e464bf110456cec16d8e03175d2 100644
--- a/content/browser/download/save_package_browsertest.cc
+++ b/content/browser/download/save_package_browsertest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <memory>
+
#include "base/files/scoped_temp_dir.h"
#include "content/browser/download/save_package.h"
#include "content/public/test/content_browser_test.h"
@@ -40,9 +42,9 @@ IN_PROC_BROWSER_TEST_F(SavePackageBrowserTest, ImplicitCancel) {
NavigateToURL(shell(), url);
base::FilePath full_file_name, dir;
GetDestinationPaths("a", &full_file_name, &dir);
- scoped_refptr<SavePackage> save_package(new SavePackage(
- shell()->web_contents(), SAVE_PAGE_TYPE_AS_ONLY_HTML, full_file_name,
- dir));
+ std::unique_ptr<SavePackage> save_package(
+ new SavePackage(shell()->web_contents(), SAVE_PAGE_TYPE_AS_ONLY_HTML,
+ full_file_name, dir));
}
// Create a SavePackage, call Cancel, then delete it.
@@ -53,9 +55,9 @@ IN_PROC_BROWSER_TEST_F(SavePackageBrowserTest, ExplicitCancel) {
NavigateToURL(shell(), url);
base::FilePath full_file_name, dir;
GetDestinationPaths("a", &full_file_name, &dir);
- scoped_refptr<SavePackage> save_package(new SavePackage(
- shell()->web_contents(), SAVE_PAGE_TYPE_AS_ONLY_HTML, full_file_name,
- dir));
+ std::unique_ptr<SavePackage> save_package(
+ new SavePackage(shell()->web_contents(), SAVE_PAGE_TYPE_AS_ONLY_HTML,
+ full_file_name, dir));
save_package->Cancel(true);
}

Powered by Google App Engine
This is Rietveld 408576698