Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: content/browser/download/save_package.cc

Issue 2032283002: Remove refcounting from SavePackage. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_package.cc
diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc
index 7704eb4aae239d3bb53cf152caedcd28912f8e29..7bf3bd24041a133f51638e3a293f916e3c398eb5 100644
--- a/content/browser/download/save_package.cc
+++ b/content/browser/download/save_package.cc
@@ -342,7 +342,7 @@ void SavePackage::InitWithDownloadItem(
MHTMLGenerationParams mhtml_generation_params(saved_main_file_path_);
web_contents()->GenerateMHTML(
mhtml_generation_params,
- base::Bind(&SavePackage::OnMHTMLGenerated, this));
+ base::Bind(&SavePackage::OnMHTMLGenerated, Unretained(this)));
} else {
DCHECK_EQ(SAVE_PAGE_TYPE_AS_ONLY_HTML, save_type_);
wait_state_ = NET_FILES;
@@ -383,7 +383,8 @@ void SavePackage::OnMHTMLGenerated(int64_t size) {
}
if (download_manager_->GetDelegate()->ShouldCompleteDownload(
- download_, base::Bind(&SavePackage::Finish, this))) {
+ download_,
+ base::Bind(&SavePackage::Finish, base::Unretained(this)))) {
Finish();
}
}
@@ -1382,8 +1383,9 @@ void SavePackage::GetSaveInfo() {
std::string mime_type = web_contents()->GetContentsMimeType();
BrowserThread::PostTask(
BrowserThread::FILE, FROM_HERE,
- base::Bind(&SavePackage::CreateDirectoryOnFileThread, this,
- website_save_dir, download_save_dir, skip_dir_check, mime_type));
+ base::Bind(&SavePackage::CreateDirectoryOnFileThread,
+ base::Unretained(this), website_save_dir, download_save_dir,
+ skip_dir_check, mime_type));
}
void SavePackage::CreateDirectoryOnFileThread(
@@ -1430,8 +1432,8 @@ void SavePackage::CreateDirectoryOnFileThread(
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
- base::Bind(&SavePackage::ContinueGetSaveInfo, this, save_dir,
- can_save_as_complete));
+ base::Bind(&SavePackage::ContinueGetSaveInfo, base::Unretained(this),
+ save_dir, can_save_as_complete));
}
void SavePackage::ContinueGetSaveInfo(const base::FilePath& suggested_path,

Powered by Google App Engine
This is Rietveld 408576698