Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 203065: Enable the ability to run layout tests on Vista as well as XP. See the note ... (Closed)

Created:
11 years, 3 months ago by Dirk Pranke
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Enable the ability to run layout tests on Vista as well as XP. See the note sent to chromium-dev for more info. This change changes test_shell to use --generic-theme when --layout-tests is specified. Also, two new platform directories have been added for baselines, chromium-win-xp and chromium-win-vista. chromium-win-vista should be empty (it just needs to exist for run_webkit_tests.py to function properly), and chromium-win-xp should contain only XP-specific baselines. In addition to this change, we will commit a new set of baselines directly using svn (rather than going through Rietveld). R=TBD BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26203

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M webkit/tools/layout_tests/layout_package/platform_utils_win.py View 2 chunks +5 lines, -1 line 1 comment Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +11 lines, -4 lines 1 comment Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
11 years, 3 months ago (2009-09-15 11:17:50 UTC) #1
darin (slow to review)
11 years, 3 months ago (2009-09-15 16:23:57 UTC) #2
http://codereview.chromium.org/203065/diff/1/3
File webkit/tools/layout_tests/layout_package/platform_utils_win.py (right):

http://codereview.chromium.org/203065/diff/1/3#newcode25
Line 25: elif winver[0] == 5 and (winver[1] == 1 or winver[1] == 2):
nit: no need for else after return.  just do "if" instead of "elif"

http://codereview.chromium.org/203065/diff/1/2
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/203065/diff/1/2#newcode2335
Line 2335: BUG21859 WIN-XP : LayoutTests/fast/text/line-breaks.html = FAIL
it seems strange that we would regress XP behavior.  what happened there?

Powered by Google App Engine
This is Rietveld 408576698