Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: webkit/tools/layout_tests/layout_package/platform_utils_win.py

Issue 203065: Enable the ability to run layout tests on Vista as well as XP. See the note ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/layout_tests/layout_package/platform_utils_win.py
===================================================================
--- webkit/tools/layout_tests/layout_package/platform_utils_win.py (revision 26193)
+++ webkit/tools/layout_tests/layout_package/platform_utils_win.py (working copy)
@@ -20,7 +20,9 @@
'-snowleopard'. If the platform does not distinguish between
minor versions, it returns ''."""
winver = sys.getwindowsversion()
- if winver[0] == 5 and (winver[1] == 1 or winver[1] == 2):
+ if winver[0] == 6 and (winver[1] == 0):
+ return '-vista'
+ elif winver[0] == 5 and (winver[1] == 1 or winver[1] == 2):
darin (slow to review) 2009/09/15 16:23:57 nit: no need for else after return. just do "if"
return '-xp'
return ''
@@ -28,6 +30,8 @@
"""Returns the list of directories to search for baselines/results, in
order of preference. Paths are relative to the top of the source tree."""
dirs = []
+ if PlatformVersion() in ("-vista", "-xp"):
+ dirs.append(path_utils.ChromiumBaselinePath('chromium-win-vista'))
if PlatformVersion() == "-xp":
dirs.append(path_utils.ChromiumBaselinePath('chromium-win-xp'))
dirs.append(path_utils.ChromiumBaselinePath('chromium-win'))
« no previous file with comments | « no previous file | webkit/tools/layout_tests/test_expectations.txt » ('j') | webkit/tools/layout_tests/test_expectations.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698