Issue 203001: Don't do a default browser check when new tabs are opened via the command line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203001: Don't do a default browser check when new tabs are opened via the command line. (Closed)

Created:
11 years, 3 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't do a default browser check when new tabs are opened via the command line. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25777

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/browser_init.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

not_the_right_dank

11 years, 3 months ago (2009-09-09 18:38:38 UTC) #2

Lgtm

On Sep 9, 2009 11:30 AM, <mdm@chromium.org> wrote:


Reviewers: dank,

Description:
Don't do a default browser check when new tabs are opened via the
command line.
BUG=none
TEST=none


Please review this at http://codereview.chromium.org/203001

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
 M     chrome/browser/browser_init.cc


Index: chrome/browser/browser_init.cc
===================================================================
--- chrome/browser/browser_init.cc      (revision 25674)
+++ chrome/browser/browser_init.cc      (working copy)
@@ -467,7 +467,8 @@
    }
 #endif
    // Check whether we are the default browser.
-    if (!command_line_.HasSwitch(switches::kNoDefaultBrowserCheck))
+    if (process_startup &&
+        !command_line_.HasSwitch(switches::kNoDefaultBrowserCheck))
      CheckDefaultBrowser(profile);
  } else {
    RecordLaunchModeHistogram(LM_AS_WEBAPP);

Expand Messages | Collapse Messages