Issue 2027006: Disallow display of multiple experimental.extension.popup(...) windows...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2027006: Disallow display of multiple experimental.extension.popup(...) windows... (Closed)

Created:
10 years, 7 months ago by Eric Dingle

Modified:
9 years, 7 months ago

Reviewers:
Jeff Timanus

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Disallow display of multiple experimental.extension.popup(...) windows Patch 1 contains twiz@'s code reviewed implementation from http://codereview.chromium.org/1512007 BUG=None TEST=ExtensionApiTest.Popup

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -90 lines)			Patch
M	chrome/browser/extensions/extension_host.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_popup_api.cc	View	1	14 chunks	+67 lines, -19 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/extension.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/history.html	View		30 chunks	+61 lines, -61 lines	0 comments	Download
M	chrome/common/notification_type.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_process_bindings.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/popup/toolband.html	View	1	3 chunks	+62 lines, -4 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/popup/toolband_popup_a.html	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/popup/toolband_popup_b.html	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Jeff Timanus

10 years, 7 months ago (2010-05-11 18:25:24 UTC) #1

LGTM.

Thanks for following up with your investigation, Eric.

http://codereview.chromium.org/2027006/diff/1/15
File chrome/test/data/extensions/api_test/popup/toolband.html (right):

http://codereview.chromium.org/2027006/diff/1/15#newcode167
chrome/test/data/extensions/api_test/popup/toolband.html:167:
chrome.test.log('Hello?');
Thanks for removing that.

Expand Messages | Collapse Messages