chrome/renderer/extensions/extension_process_bindings.cc - Issue 2027006: Disallow display of multiple experimental.extension.popup(...) windows...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_process_bindings.cc

Issue 2027006: Disallow display of multiple experimental.extension.popup(...) windows... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/extension_process_bindings.cc

===================================================================

--- chrome/renderer/extensions/extension_process_bindings.cc (revision 46927)

+++ chrome/renderer/extensions/extension_process_bindings.cc (working copy)

@@ -299,7 +299,7 @@

if (0 == popup_matcher.views()->Length())

return v8::Undefined();

- DCHECK(popup_matcher.views()->Has(0));

+ DCHECK(1 == popup_matcher.views()->Length());

// Return the first view found.

return popup_matcher.views()->Get(v8::Integer::New(0));

« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »