Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: base/weak_ptr_unittest.cc

Issue 202057: Replace EXPECT_EQ(NULL, foo) with EXPECT_TRUE(NULL == foo).... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/weak_ptr_unittest.cc
===================================================================
--- base/weak_ptr_unittest.cc (revision 27387)
+++ base/weak_ptr_unittest.cc (working copy)
@@ -54,13 +54,13 @@
TEST(WeakPtrTest, OutOfScope) {
WeakPtr<int> ptr;
- EXPECT_EQ(NULL, ptr.get());
+ EXPECT_TRUE(ptr.get() == NULL);
{
int data;
WeakPtrFactory<int> factory(&data);
ptr = factory.GetWeakPtr();
}
- EXPECT_EQ(NULL, ptr.get());
+ EXPECT_TRUE(ptr.get() == NULL);
}
TEST(WeakPtrTest, Multiple) {
@@ -73,8 +73,8 @@
EXPECT_EQ(&data, a.get());
EXPECT_EQ(&data, b.get());
}
- EXPECT_EQ(NULL, a.get());
- EXPECT_EQ(NULL, b.get());
+ EXPECT_TRUE(a.get() == NULL);
+ EXPECT_TRUE(b.get() == NULL);
}
TEST(WeakPtrTest, UpCast) {
@@ -98,7 +98,7 @@
EXPECT_EQ(&data, ptr.get());
EXPECT_TRUE(factory.HasWeakPtrs());
factory.InvalidateWeakPtrs();
- EXPECT_EQ(NULL, ptr.get());
+ EXPECT_TRUE(ptr.get() == NULL);
EXPECT_FALSE(factory.HasWeakPtrs());
}

Powered by Google App Engine
This is Rietveld 408576698