Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 202057: Replace EXPECT_EQ(NULL, foo) with EXPECT_TRUE(NULL == foo).... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_auth_cache_unittest.cc ('k') | net/proxy/single_threaded_proxy_resolver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
===================================================================
--- net/http/http_network_transaction_unittest.cc (revision 27387)
+++ net/http/http_network_transaction_unittest.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
wtc 2009/10/02 23:59:32 I thought we should change 2006-2008 to 2006-2
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -2757,19 +2757,19 @@
trans->ResetStateForRestart();
// Verify that the state that needed to be reset, has been reset.
- EXPECT_EQ(NULL, trans->header_buf_->headers());
+ EXPECT_TRUE(trans->header_buf_->headers() == NULL);
EXPECT_EQ(0, trans->header_buf_capacity_);
EXPECT_EQ(0, trans->header_buf_len_);
EXPECT_EQ(-1, trans->header_buf_body_offset_);
EXPECT_EQ(-1, trans->header_buf_http_offset_);
EXPECT_EQ(-1, trans->response_body_length_);
EXPECT_EQ(0, trans->response_body_read_);
- EXPECT_EQ(NULL, trans->read_buf_.get());
+ EXPECT_TRUE(trans->read_buf_.get() == NULL);
EXPECT_EQ(0, trans->read_buf_len_);
EXPECT_EQ("", trans->request_headers_->headers_);
EXPECT_EQ(0U, trans->request_headers_bytes_sent_);
- EXPECT_EQ(NULL, trans->response_.auth_challenge.get());
- EXPECT_EQ(NULL, trans->response_.headers.get());
+ EXPECT_TRUE(trans->response_.auth_challenge.get() == NULL);
+ EXPECT_TRUE(trans->response_.headers.get() == NULL);
EXPECT_EQ(false, trans->response_.was_cached);
EXPECT_EQ(0, trans->response_.ssl_info.cert_status);
EXPECT_FALSE(trans->response_.vary_data.is_valid());
« no previous file with comments | « net/ftp/ftp_auth_cache_unittest.cc ('k') | net/proxy/single_threaded_proxy_resolver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698