Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 202057: Replace EXPECT_EQ(NULL, foo) with EXPECT_TRUE(NULL == foo).... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_base_unittest.cc
===================================================================
--- net/socket/client_socket_pool_base_unittest.cc (revision 27387)
+++ net/socket/client_socket_pool_base_unittest.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -340,11 +340,8 @@
virtual void OnConnectJobComplete(int result, ConnectJob* job) {
result_ = result;
scoped_ptr<ClientSocket> socket(job->ReleaseSocket());
- if (result == OK) {
- EXPECT_TRUE(socket.get() != NULL);
- } else {
- EXPECT_EQ(NULL, socket.get());
- }
+ // socket.get() should be NULL iff result != OK
+ EXPECT_EQ(socket.get() == NULL, result != OK);
delete job;
have_result_ = true;
if (waiting_for_result_)

Powered by Google App Engine
This is Rietveld 408576698