Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 202045: sync-webkit-git: reduce diff-index output (Closed)

Created:
11 years, 3 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
kuchhal
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

sync-webkit-git: reduce diff-index output We run diff-index to see if there are any changes we need to pull in, but we don't need it to print all of those changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/sync-webkit-git.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
11 years, 3 months ago (2009-09-10 16:47:04 UTC) #1
kuchhal
11 years, 3 months ago (2009-09-10 17:03:34 UTC) #2
lgtm.

On Thu, Sep 10, 2009 at 9:47 AM, <evan@chromium.org> wrote:

> Reviewers: kuchhal,
>
> Description:
> sync-webkit-git: reduce diff-index output
>
> We run diff-index to see if there are any changes we need to pull in,
> but we don't need it to print all of those changes.
>
> Please review this at http://codereview.chromium.org/202045
>
> Affected files:
>  M tools/sync-webkit-git.py
>
>
> Index: tools/sync-webkit-git.py
> diff --git a/tools/sync-webkit-git.py b/tools/sync-webkit-git.py
> index
>
0de9d409ac77d9adca8df99714d68901abb5b32b..469d82bd076112c77ead6e251de5a825c8543453
> 100755
> --- a/tools/sync-webkit-git.py
> +++ b/tools/sync-webkit-git.py
> @@ -75,7 +75,8 @@ def UpdateCurrentCheckoutIfAppropriate():
>     print "Run 'git checkout gclient' to put this under control of
> gclient."
>     return
>
> -  if subprocess.call(['git', 'diff-index', '--exit-code', 'HEAD']):
> +  if subprocess.call(['git', 'diff-index', '--exit-code', '--shortstat',
> +                     'HEAD']):
>     print "Resetting tree state to new revision."
>     subprocess.check_call(['git', 'reset', '--hard'])
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698