Issue 202040: Roll new googleurl to update WebSocket default port

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202040: Roll new googleurl to update WebSocket default port (Closed)

Created:
11 years, 3 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Roll new googleurl to update WebSocket default port BUG=12497 TEST=googleurl_unittsts URLCanonTest.CanonicalizeStandardURL passes.

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

11 years, 3 months ago (2009-09-10 04:49:12 UTC) #2

lgtm

On Wed, Sep 9, 2009 at 8:21 PM, <ukai@chromium.org> wrote:
> Reviewers: willchan,
>
> Description:
> Roll new googleurl to update WebSocket default port
>
> BUG=3D12497
> TEST=3Dgoogleurl_unittsts URLCanonTest.CanonicalizeStandardURL passes.
>
> Please review this at http://codereview.chromium.org/202040
>
> Affected files:
> =A0M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index
> 9dcb54504811ef1ee2a47db760d2839608af8e95..9404c253526a64ba17aee4bd0ecbefe=
d98324f52
> 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -13,7 +13,7 @@ deps =3D {
> =A0 =A0 "/trunk/deps/support@20411",
>
> =A0 "src/googleurl":
> - =A0 =A0"http://google-url.googlecode.com/svn/trunk@115",
> + =A0 =A0"http://google-url.googlecode.com/svn/trunk@116",
>
> =A0 "src/sdch/open-vcdiff":
> =A0 =A0 "http://open-vcdiff.googlecode.com/svn/trunk@26",
>
>
>

Expand Messages | Collapse Messages