Fixes regression introduced in dnd refactoring. I removed a check for...

Fixes regression introduced in dnd refactoring. I removed a check for
the URL that I shouldn't have (it won't be needed at some point, but it
is now).

BUG=21198
TEST=Select a URL and drag to the tab strip. Make sure you get the
     drop target and you can drop the text to create a new tab. Do the
     same with www.google.com, you shouldn't get a drop target.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25653

[Peter Kasting, 2009-09-08 17:25:26]

This makes me super-sad because it fixes the problem in the opposite of the
desired way.  I want to be able to drag a .jpg from the download shelf, or some
text from on the page, up to the tabstrip and drop it successfully.  Is that so
hard to support?

[sky, 2009-09-08 19:22:38]

I wouldn't want you to be sad, let alone super-sad. I've updated the
patch to give it 'paste and go' support, which I believe is what
you're asking for. Note that dragging jpg's from the download shelf
already worked as we put a URL for the file on pasteboard in that
case.

  -Scott

On Tue, Sep 8, 2009 at 10:25 AM, <pkasting@chromium.org> wrote:
> This makes me super-sad because it fixes the problem in the opposite of
> the desired way. =A0I want to be able to drag a .jpg from the download
> shelf, or some text from on the page, up to the tabstrip and drop it
> successfully. =A0Is that so hard to support?
>
> http://codereview.chromium.org/202010
>

[sky, 2009-09-08 19:28:40]

Jay, I'm passing your way as I believe Ben is out.

[Peter Kasting, 2009-09-08 19:43:48]

On 2009/09/08 19:22:38, sky wrote:
> I wouldn't want you to be sad, let alone super-sad. I've updated the
> patch to give it 'paste and go' support, which I believe is what
> you're asking for. Note that dragging jpg's from the download shelf
> already worked as we put a URL for the file on pasteboard in that
> case.

Rad.  Given this patch we should probably factor out paste-and-go stuff into a
completely separate class from the AutocompleteEditModel since it doesn't really
make sense to have people calling into the location bar for this sort of thing. 
Can you file a bug to do that?

[sky, 2009-09-08 19:46:24]

Will do. Let me land this then I'll file another bug.

  -Scott

On Tue, Sep 8, 2009 at 12:43 PM, <pkasting@chromium.org> wrote:
> On 2009/09/08 19:22:38, sky wrote:
>>
>> I wouldn't want you to be sad, let alone super-sad. I've updated the
>> patch to give it 'paste and go' support, which I believe is what
>> you're asking for. Note that dragging jpg's from the download shelf
>> already worked as we put a URL for the file on pasteboard in that
>> case.
>
> Rad. =A0Given this patch we should probably factor out paste-and-go stuff
> into a completely separate class from the AutocompleteEditModel since it
> doesn't really make sense to have people calling into the location bar
> for this sort of thing. =A0Can you file a bug to do that?
>
> http://codereview.chromium.org/202010
>

[jcampan, 2009-09-08 20:19:01]

OK

http://codereview.chromium.org/202010/diff/3001/1005
File chrome/browser/views/frame/browser_root_view.h (right):

http://codereview.chromium.org/202010/diff/3001/1005#newcode51
Line 51: GURL* url);
Nit: Can't this fit on one line?