Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: src/globals.h

Issue 20177: Support for building V8 with MinGW (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/dtoa-config.c ('k') | src/platform.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/globals.h
===================================================================
--- src/globals.h (revision 1238)
+++ src/globals.h (working copy)
@@ -30,10 +30,10 @@
// -----------------------------------------------------------------------------
// Types
-// Windows is missing the stdint.h header file. Instead we define standard
-// integer types for Windows here.
+// Visual Studio C++ is missing the stdint.h header file. Instead we define
+// standard integer types for Windows here.
-#ifdef WIN32
+#ifdef _MSC_VER
typedef signed char int8_t;
typedef unsigned char uint8_t;
typedef short int16_t; // NOLINT
@@ -42,9 +42,9 @@
typedef unsigned int uint32_t;
typedef __int64 int64_t;
typedef unsigned __int64 uint64_t;
-#else
+#else // _MSC_VER
#include <stdint.h> // for intptr_t
-#endif
+#endif // _MSC_VER
namespace v8 { namespace internal {
@@ -464,8 +464,10 @@
#define TRACK_MEMORY(name)
#endif
-// define used for helping GCC to make better inlining.
-#ifdef __GNUC__
+// define used for helping GCC to make better inlining. Don't bother for debug
+// builds. On GCC 3.4.5 using __attribute__((always_inline)) causes compilation
+// errors in debug build.
+#if defined(__GNUC__) && !defined(DEBUG)
#if (__GNUC__ >= 4)
#define INLINE(header) inline header __attribute__((always_inline))
#else
« no previous file with comments | « src/dtoa-config.c ('k') | src/platform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698