Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20176: Moved some IA32 specific code from to the architecture dependent part of the ... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Moved some IA32 specific code from to the architecture dependent part of the debugger code. Renamed functions related to patching of code with call instructions to match the naming conversion. BUG=1240753 Committed: http://code.google.com/p/v8/source/detail?r=1239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -44 lines) Patch
M src/assembler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/assembler-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/assembler-arm-inl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/assembler-ia32-inl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/debug.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M src/debug-arm.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/debug-ia32.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-09 10:42:09 UTC) #1
Kevin Millikin (Chromium)
11 years, 10 months ago (2009-02-09 12:16:39 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698